1230784 - Video distortion on 5+ min videos on YouTube

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect)

Description

[tw-bugs-firefox]

User Agent: Mozilla/5.0 (Android 6.0; Mobile; rv:45.0) Gecko/45.0 Firefox/45.0
Build ID: 20151205030208

Steps to reproduce:

Open a video on mobile YouTube, preferably one that is 7 minutes or longer. Watch the video in full screen. It will eventually distort into a stretched version of only a few rows/columns of pixels of itself (unviewable). See here for an example of this phenomenon: https://youtu.be/e9jdCKKT5N0
Tested on latest nightly (2015-12-05) and latest main build (42.0.2).


Actual results:

Video distorted itself.


Expected results:

Video dimensions remain appropriate.

Comment 1

[tw-bugs-firefox]

Attachment: logcat of event

Example video was taken down. I made another one with Big Buck Bunny instead: https://youtu.be/0JY_dgedteI
5:55 or so showcases the glitch.
I have tried to get relevant info from adb logcat multiple times but no luck. The event in the video was around 14:35:35. Log attached...

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

I have seen this on the 5x. What device are you using?

Comment 3

[tw-bugs-firefox]

My bad... Nexus 6P.

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

This is fairly bad. Might be Android 6.0 or 5x/6p specific. Have anyone who can look into this?

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

I can reproduce this on Nightly, 6P. Seemed to distort after about 6 minutes. Nothing interesting in logcat. It looks like it could be a compositing problem (busted triangle strip?), but I'm not sure how that could happen.

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

Benoit, Nicolas, does this seem like compositor bustage to you? See comment #1

Comment 7

[James Willcox (:snorp) ([e-mail]) (he/him)]

A couple other interesting notes:

1) Once the corruption occurs, seeking to the beginning of the file still results in corrupted output.
2) If I exit fullscreen, everything else on the page looks fine, but the video remains corrupted

I am sorta thinking this is MSE specific or even YouTube specific. Anthony, have you ever seen anything like this?

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

I can reproduce this on vimeo too, which I don't believe is using MSE. That probably narrows it down to either decoder weirdness (unlikely) or compositor/gfx badness.

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

This seems to be yet another bug caused by us copying the video surface for presentation. Time to rip it out for real -- causing more problems than it solves at this point.

Comment 10

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Don't copy SurfaceTexture contents when presenting video on Android

This has caused a lot of problems, we should just stop. It's possible now that video/audio could
be out of sync by a few frames, but in practice I don't really notice anything.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6e4e4e058354

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6e4e4e058354

Comment 13

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8700048 [details] [diff] [review]
Don't copy SurfaceTexture contents when presenting video on Android

Approval Request Comment
[Feature/regressing bug #]: Marshmallow?
[User impact if declined]: Distorted video after about 5 minutes on Android 6.0 devices
[Describe test coverage new/current, TreeHerder]: Nightly
[Risks and why]: Low, but there is a possibility for slight AV sync issues. I haven't seen anything in testing.
[String/UUID change made/needed]: None

Comment 14

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

[e-mail], could you please verify this issue is fixed as expected on a latest Nightly build? Thanks!

Comment 15

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8700048 [details] [diff] [review]
Don't copy SurfaceTexture contents when presenting video on Android

Taking this in Aurora45 for now, will wait a few days of additional verification before uplifting to Beta44.

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a8de44cf17d3

Comment 17

[tw-bugs-firefox]

It is absolutely fixed! :-) Thank you! I tested it for at least an hour the other day. I didn't reply earlier ith findings because someone else marked it fixed. (I am kind of new to the bug tracker.)

Comment 18

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

(In reply to tw-bugs-firefox from comment #17)
> It is absolutely fixed! :-) Thank you! I tested it for at least an hour the
> other day. I didn't reply earlier ith findings because someone else marked
> it fixed. (I am kind of new to the bug tracker.)

Fantastic. Thank you for a prompt reply!

Comment 19

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8700048 [details] [diff] [review]
Don't copy SurfaceTexture contents when presenting video on Android

The fix was verified, Beta44+

Comment 20

[Carsten Book [:Tomcat]]

has problems to apply to beta:

grafting 321565:a8de44cf17d3 "Bug 1230784 - Don't copy SurfaceTexture contents when presenting video on Android r=esawin,jya a=ritu"
merging dom/media/platforms/android/AndroidDecoderModule.cpp
warning: conflicts while merging dom/media/platforms/android/AndroidDecoderModule.cpp! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use hg resolve and hg graft --continue)

Comment 23

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/releases/mozilla-beta/rev/27eda69e75d7

Comment 24

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Marking 44 fixed per comment 23.

Comment 25

[Teodora Vermesan (:TeoVermesan)]

I was able to reproduce the issue on Firefox for Android 44 Beta 7 using Nexus 6 (Android 6.0).
Verified as fixed on Firefox for Android 44 Beta 8.

Comment 26

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/27eda69e75d7

Comment 27

[Teodora Vermesan (:TeoVermesan)]

Verified as fixed on:
Device: Nexus 6 (Android 6.0)
Build: Firefox for Android 46.0a1 (2016-01-17)

Comment 28

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8700048 [details] [diff] [review]
Don't copy SurfaceTexture contents when presenting video on Android

Mozilla-release branch is now Fx44 and this patch already landed in Beta44. Clearing out the m-r:? flag.

Comment 29

[Teodora Vermesan (:TeoVermesan)]

Verified as fixed on:
Device: Nexus 6 (Android 6.0)
Build: Firefox for Android 45.0a2 (2016-01-24)