1230843 - ReferenceError: AppConstants is not defined when trying to close the last conversation tab.

Status: RESOLVED FIXED

(Instantbird Graveyard :: Conversation, defect)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

Trying to close the tab using any of the following does nothing visible except causing the error below in the console: Cmd+W, Escape, middle clicking the tab, clicking the tab's x button, close/put on hold from the tab's context menu.

Timestamp: 12/7/15, 3:15:28 AM
Error: ReferenceError: AppConstants is not defined
Source File: chrome://global/content/globalOverlay.js
Line: 8

Clicking the window's x button successfully closes the tab with no errors in the console.

Closing the window causes conversations to be put in a weird state where it appears that Ib thinks that they are on hold, but they don't show up in the blist, and trying to join a channel that was closed results in it stuck in the "joining" state forever.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

> Closing the window causes conversations to be put in a weird state where it
> appears that Ib thinks that they are on hold, but they don't show up in the
> blist, and trying to join a channel that was closed results in it stuck in
> the "joining" state forever.

Scratch this part, turns out it was a result of me messing with an about:config flag and assuming that it was stuck at the "joining" state when really I just needed to wait another second.

Comment 2

[aleth [:aleth]]

Attachment: Add AppConstants to instantbird.js

Comment 3

[aleth [:aleth]]

Background: m-c is replacing some ifdefs with Appconstant.platform checks. See bug 1229519

Comment 4

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/982a9b6b77b2ce4907272ae4374a44e715650b8e
Bug 1230843 - Add AppConstants to instantbird.js. r=clokep