Closed Bug 1230844 Opened 4 years ago Closed 4 years ago

Reminder dialog is sometimes not displayed if reminders fire at startup

Categories

(Calendar :: Alarms, defect)

Lightning 4.6
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mmecca, Assigned: mmecca)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Sometimes the reminder dialog doesn't open if missed alarms fire at startup, likely due to a timing issue where the alarm service finishes it's initial load after the dialog has been created but before it's onLoad event has been processed.
Blocks: 1110183
No longer blocks: 110183
Component: Dialogs → Alarms
Blocks: 1230837
Attached patch Fix v1Splinter Review
Attachment #8696368 - Flags: review?(philipp)
Attachment #8696368 - Flags: approval-calendar-aurora?(philipp)
Comment on attachment 8696368 [details] [diff] [review]
Fix v1

Review of attachment 8696368 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=philipp. Is this also needed on other branches?
Attachment #8696368 - Flags: review?(philipp)
Attachment #8696368 - Flags: review+
Attachment #8696368 - Flags: approval-calendar-aurora?(philipp)
Attachment #8696368 - Flags: approval-calendar-aurora+
(In reply to Philipp Kewisch [:Fallen] from comment #2)
>Is this also needed on other branches?

Only if we backported the fix for Bug 1110183, but considering there are other potentially related issues like those reported in Bug 1230837 I think we should leave it at 4.6 for now.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/8783ea56dab57b4cc8b0cc81a322adce409772a9
Bug 1230844 - Reminder dialog is sometimes not displayed if reminders fire at startup. r+a=philipp
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.7
Still needs to be checked-in on comm-aurora
Keywords: checkin-needed
You're probably wanting this to go to beta instead of aurora, as it's already in 4.7?
Comment on attachment 8696368 [details] [diff] [review]
Fix v1

The approval is stale, so this needs to go to bet now
Attachment #8696368 - Flags: approval-calendar-beta+
Backported to releases/comm-beta changeset 8bfffb4cf500
Keywords: checkin-needed
Target Milestone: 4.7 → 4.6
You need to log in before you can comment on or make changes to this bug.