1230911 - [Static Analysis][Dereference before null check] In function TextureClient::CreateForDrawing from TextureClient.cpp

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added that pointer aAllocator is dereferenced before null check, that could resul to a null poinder dereference.

Comment 1

[Andi [:andi]]

Attachment: Bug 1230911.diff

Hello Robert,

Can you please take a look other this patch?

THX

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8696442 [details] [diff] [review]
Bug 1230911.diff

Review of attachment 8696442 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/client/TextureClient.cpp
@@ +693,5 @@
>                                  TextureFlags aTextureFlags,
>                                  TextureAllocationFlags aAllocFlags)
>  {
> +  // also test the validity of aAllocator
> +  MOZ_ASSERT(aAllocator ? aAllocator->IPCOpen() : false);

Same here:
MOZ_ASSERT(aAllocator && aAllocator->IPCOpen()).

By the way if you're going to suggest exactly the same patch in different places, it's easier to combine them into one patch.

Comment 3

[Andi [:andi]]

Attachment: Bug 1230911.diff

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/18069b9f03e1

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/18069b9f03e1

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f0e4fac70177

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f0e4fac70177