1230972 - Uninitialized value $user_id when Bugzilla_login is missing

Status: UNCONFIRMED

(Bugzilla :: WebService, defect)

Description

[Alex Schuilenburg]

Attachment: Patch to check for !defined $user_id prior to use of value

Since upgrading to 5.0.1 our server error log is throwing up a number of these lines:

jsonrpc.cgi: Use of uninitialized value $user_id in numeric ne (!=) at Bugzilla/Auth/Login/Cookie.pm line 61., referer: <removed>/show_bug.cgi?id=<removed>

I am not sure why/how this occurs, but a quick inspection of the code shows $user_id can fall through uninitialised if there is no Bugzilla_logincookie.

A simple subsequent check for !defined $userid will avoid the error in the logs but provide the same behaviour

Comment 1

[Frédéric Buclin]

Comment on attachment 8696499 [details] [diff] [review]
Patch to check for !defined $user_id prior to use of value

>+                || !defined $user_id

!$user_id would do it too as an empty $user_id and 0 are both illegal.