1231035 - HPKP periodic updates broken on mozilla-esr38

Status: RESOLVED DUPLICATE of bug 1224968

(Release Engineering :: General, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

eg http://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-esr38-linux64/mozilla-esr38-linux64-periodicupdate-bm72-build1-build0.txt.gz

INFO: Generating new HPKP preload list...
INFO: Running "LD_LIBRARY_PATH=/builds/slave/m-esr38-l64-periodicupdate-000/gtk3/usr/local/lib:. ./xpcshell /builds/slave/m-esr38-l64-periodicupdate-000/genHPKPStaticPins.js /builds/slave/m-esr38-l64-periodicupdate-000/PreloadedHPKPins.json /builds/slave/m-esr38-l64-periodicupdate-000/default-ee.der /builds/slave/m-esr38-l64-periodicupdate-000/firefox/StaticHPKPins.h"
INFO: Checking whether new HPKP preload list is valid...
New StaticHPKPins.errors error list is empty. I guess that's good?
StaticHPKPins.h is empty. That's less good.
program finished with exit code 52

Last worked in
 http://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-esr38-linux64/mozilla-esr38-linux64-periodicupdate-bm94-build1-build0.txt.gz
on Nov 14, although there was an infra failure on the 21st which may have masked the real regression window.

Comment 1

[:Cykesiopka]

So I checked out mozilla-esr38 locally, and it looks like Attachment 8694062 [details] [diff] from Bug 1224968 fixes the script locally.

I'm not entirely sure why StaticHPKPins.h would end up empty, or why the script just seems to stop and not print out anything when an exception is thrown (such as when purposefully not giving the required arguments).

I already requested uplifting the Bug 1224968 patch to esr38, so we can probably wait to see if that fixes it in automation as well.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Thanks for the debugging. Lets dupe over to the other bug.