123105 - No tooltips in duplicates.cgi

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement, P3)

Description

[Brian 'netdragon' Bober]

We need tooltips in duplicates.cgi

Comment 1

[Dave Miller [:justdave]]

Enhancements which don't currently have patches on them which are targetted at
2.18 are being retargetted to 2.20 because we're about to freeze for 2.18. 
Consideration will be taken for moving items back to 2.18 on a case-by-case
basis (but is unlikely for enhancements)

Comment 2

[Dave Miller [:justdave]]

Bugzilla 2.20 feature set is now frozen as of 15 Sept 2004.  Anything flagged
enhancement that hasn't already landed is being pushed out.  If this bug is
otherwise ready to land, we'll handle it on a case-by-case basis, please set the
blocking2.20 flag to '?' if you think it qualifies.

Comment 3

[Dave Miller [:justdave]]

Reassigning bugs that I'm not actively working on to the default component owner
in order to try to make some sanity out of my personal buglist.  This doesn't
mean the bug isn't being dealt with, just that I'm not the one doing it.  If you
are dealing with this bug, please assign it to yourself.

Comment 4

[victory <[e-mail]>]

Attachment: patch for tip, bug_link filter added

Comment 5

[Frédéric Buclin]

Comment on attachment 237451 [details] [diff] [review]
patch for tip, bug_link filter added

>+              <a href="show_bug.cgi?id=[% bug.id %]">[% bug.id FILTER bug_link(bug.id) FILTER closed(isclosed) %]</a>

Have a look at other templates to see how FILTER bug_link works. What is done here is wrong.

Comment 6

[victory <[e-mail]>]

Attachment: patch for tip v2

Comment 7

[Frédéric Buclin]

Comment on attachment 237465 [details] [diff] [review]
patch for tip v2

>+              [% bug.id FILTER closed(isclosed) FILTER bug_link(bug.id) %]

FILTER bug_link() already uses the bz_closed class if the bug is resolved. You don't need FILTER closed() at all when using FILTER bug_link(). Do not forget to remove above this one as we don't need isclosed anymore.

Comment 8

[victory <[e-mail]>]

Attachment: patch for tip v3

argh

Comment 9

[victory <[e-mail]>]

Attachment: v3 has a wrong test code ;'(

Comment 10

[Frédéric Buclin]

Comment on attachment 237472 [details] [diff] [review]
v3 has a wrong test code ;'(

>Index: template/en/default/reports/duplicates-table.html.tmpl

>             <center>
>               [% isclosed = bug.resolution != "" %]

We don't need this line anymore as we don't use isclosed *at all*. Else your patch looks good. r=LpSolit with this line removed.

Comment 11

[victory <[e-mail]>]

Attachment: docs patch for tip v5

removed the line

Comment 12

[victory <[e-mail]>]

(In reply to comment #11)
> docs patch for tip v5
not a docs patch :-(

Comment 13

[Frédéric Buclin]

Checking in template/en/default/filterexceptions.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v  <--  filterexceptions.pl
new revision: 1.78; previous revision: 1.77
done
Checking in template/en/default/reports/duplicates-table.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/duplicates-table.html.tmpl,v  <--  duplicates-table.html.tmpl
new revision: 1.13; previous revision: 1.12
done