1231100 - Get rid of nsIDOMFileReader

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

Attachment: fileReader4.patch

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 8696655 [details] [diff] [review]
fileReader4.patch

Review of attachment 8696655 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/FileReader.h
@@ +46,5 @@
>    NS_DECL_NSITIMERCALLBACK
>    NS_DECL_NSIINPUTSTREAMCALLBACK
>    NS_DECL_NSIINTERFACEREQUESTOR
>  
>    NS_REALLY_FORWARD_NSIDOMEVENTTARGET(DOMEventTargetHelper)

You can remove this now, can't you?

@@ +104,4 @@
>  private:
>    virtual ~FileReader();
>  
> +  // This must be in sync with dom/webidl/FileReader.webidl

Can you add static asserts to that effect somewhere?

Comment 2

[Andrea Marchesini [:baku]]

Attachment: fileReader4b.patch

Removing nsIDOMFileReader, we must have way to use FileReader in some devtools script that are not running as system.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aa1fccef5994
https://hg.mozilla.org/integration/mozilla-inbound/rev/a22ade61487c

Comment 4

[Masatoshi Kimura [:emk]]

Could you use exposed=System instead of extending Cu.importGlobalProperties further?

Comment 5

[Andrea Marchesini [:baku]]

(In reply to Masatoshi Kimura [:emk] from comment #4)
> Could you use exposed=System instead of extending Cu.importGlobalProperties
> further?

Actually I do, but some devtools scripts are not running as system and they require importGlobalProperties.

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/aa1fccef5994
https://hg.mozilla.org/mozilla-central/rev/a22ade61487c

Comment 7

[Ian O'Neill]

It would be good if this change could be added to the Firefox 45 for developers notes (https://developer.mozilla.org/en-US/Firefox/Releases/45). I spent a good 30 minutes trying to work out why I could no longer create an instance of nsIDOMFileReader in my Firefox extension.