Closed Bug 1231100 Opened 4 years ago Closed 4 years ago

Get rid of nsIDOMFileReader

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(2 files)

No description provided.
Attachment #8696655 - Flags: review?(jonas)
Comment on attachment 8696655 [details] [diff] [review]
fileReader4.patch

Review of attachment 8696655 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/FileReader.h
@@ +46,5 @@
>    NS_DECL_NSITIMERCALLBACK
>    NS_DECL_NSIINPUTSTREAMCALLBACK
>    NS_DECL_NSIINTERFACEREQUESTOR
>  
>    NS_REALLY_FORWARD_NSIDOMEVENTTARGET(DOMEventTargetHelper)

You can remove this now, can't you?

@@ +104,4 @@
>  private:
>    virtual ~FileReader();
>  
> +  // This must be in sync with dom/webidl/FileReader.webidl

Can you add static asserts to that effect somewhere?
Attachment #8696655 - Flags: review?(jonas) → review+
Removing nsIDOMFileReader, we must have way to use FileReader in some devtools script that are not running as system.
Attachment #8696971 - Flags: review?(jonas)
Could you use exposed=System instead of extending Cu.importGlobalProperties further?
Flags: needinfo?(amarchesini)
(In reply to Masatoshi Kimura [:emk] from comment #4)
> Could you use exposed=System instead of extending Cu.importGlobalProperties
> further?

Actually I do, but some devtools scripts are not running as system and they require importGlobalProperties.
Flags: needinfo?(amarchesini)
https://hg.mozilla.org/mozilla-central/rev/aa1fccef5994
https://hg.mozilla.org/mozilla-central/rev/a22ade61487c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
It would be good if this change could be added to the Firefox 45 for developers notes (https://developer.mozilla.org/en-US/Firefox/Releases/45). I spent a good 30 minutes trying to work out why I could no longer create an instance of nsIDOMFileReader in my Firefox extension.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.