1231107 - [Static Analysis][Explicit null dereferenced] Function BuildSegmentsFromValueEntries from KeyframeEffect.cpp

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added that variable animationProperty can be null thus causing a null pointer dereference on line:

>>    // Now generate the segment.
>>    AnimationPropertySegment* segment =
>>      animationProperty->mSegments.AppendElement();

This could happen when condition is false:

>>    // If we've moved on to a new property, create a new AnimationProperty
>>    // to insert segments into.
>>    if (aEntries[i].mProperty != lastProperty) {
>>      MOZ_ASSERT(aEntries[i].mOffset == 0.0f);
>>      animationProperty = aResult.AppendElement();
>>      animationProperty->mProperty = aEntries[i].mProperty;
>>      animationProperty->mWinsInCascade = true;
>>      lastProperty = aEntries[i].mProperty;
>>    }

Comment 1

[Andi [:andi]]

Attachment: Bug 1231107.diff

Hello Johnny,

Can you please take a look other this patch?

THX

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8696666 [details] [diff] [review]
Bug 1231107.diff

The relevant code is from Bug 1208951

Comment 3

[Andi [:andi]]

Thank you for the review.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6a1393f29854

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/6a1393f29854