1231109 - Remove FreeBSD code no longer supported downstream

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Jan Beich]

FreeBSD 8.x became EOL in 2015-08-01, while FreeBSD 9.1 in 2015-01-01. See URL for what's currently supported.

  $ svn cat svn://svn.freebsd.org/base/stable/8/sys/sys/param.h | egrep '_version *[0-9]+'
  #define __FreeBSD_version 804508        /* Master, propagated to newvers */
  $ svn cat svn://svn.freebsd.org/base/releng/9.0/sys/sys/param.h | egrep '_version *[0-9]+'
  #define __FreeBSD_version 900044        /* Master, propagated to newvers */
  $ svn cat svn://svn.freebsd.org/base/releng/9.1/sys/sys/param.h | egrep '_version *[0-9]+'
  #define __FreeBSD_version 901000        /* Master, propagated to newvers */

thr_self() was never documented and exposed mainly for libpthread implementation.

Comment 1

[Jan Beich]

Attachment: MozReview Request: Bug 1231109 - Drop FreeBSD checks for unsupported versions. r?jld r?jesup

Bug 1231109 - Drop FreeBSD checks for unsupported versions. r?jld r?jesup

Comment 2

[Jan Beich]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa44d567b669

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8696667 [details]
MozReview Request: Bug 1231109 - Drop FreeBSD checks for unsupported versions. r?jld r?jesup

https://reviewboard.mozilla.org/r/27391/#review24711

Comment 4

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Comment on attachment 8696667 [details]
MozReview Request: Bug 1231109 - Drop FreeBSD checks for unsupported versions. r?jld r?jesup

https://reviewboard.mozilla.org/r/27391/#review25251

Comment 5

[Jan Beich]

Comment on attachment 8696667 [details]
MozReview Request: Bug 1231109 - Drop FreeBSD checks for unsupported versions. r?jld r?jesup

Mainly to ease maintenance of ESR45 downstream.

Approval Request Comment
[Feature/regressing bug #]: None
[User impact if declined]: None
[Describe test coverage new/current, TreeHerder]: NPOTB except for #if in mbslen.c, Try in comment 2, soon on inbound
[Risks and why]: Broken build or accidentally disabled XLOCALE on OS X due to typos.
[String/UUID change made/needed]:

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/401c10d24183

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/401c10d24183

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8696667 [details]
MozReview Request: Bug 1231109 - Drop FreeBSD checks for unsupported versions. r?jld r?jesup

Removing dead code is a good thing. Taking it.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/56de1b2cdd2b