1231131 - Turn CanvasCaptureMediaStream into CanvasCaptureMediaStreamTrack

Status: NEW

(Core :: WebRTC: Audio/Video, defect, P3)

Description

[Andreas Pehrson [:pehrsons]]

Per [1], we should move the `requestFrame()` method and `canvas` attribute to a MediaStreamTrack subclass and remove the CanvasCaptureMediaStream we have now.

Let's wait for the spec update before implementing.


[1] https://github.com/w3c/mediacapture-fromelement/issues/16

Comment 1

[Martin Thomson [:mt:]]

I don't know how widely this is used, but a two-stage approach might be wise: add the new MediaStreamTrack subclass, then later remove the MediaStream subclass.

Comment 2

[Martin Thomson [:mt:]]

OK, here's the PR: https://github.com/w3c/mediacapture-fromelement/pull/18

The changes are exactly like you would imagine.  A bunch of shuffling of properties are likely needed.

If you land this, then please don't forget to add [Deprecated="xxx"] to the old properties: https://developer.mozilla.org/en-US/docs/Mozilla/WebIDL_bindings#Deprecatedtag  That might help us get rid of them faster.  I haven't looked into it, but WebIDL usage telemetry would be very helpful.  I think that's automatic, but it might pay to check.

Comment 3

[Bulk Bug Changes for mreavy's org]

Mass change P2->P3 to align with new Mozilla triage process.

Comment 4

[709922234]

Both Chrome and Safari implement CanvasCaptureMediaStreamTrack.
Only Firefox implementation CanvasCaptureMediaStream.

Comment 5

[Dietrich Ayala (:dietrich)]

Bumping for compat review as this showed up in the W3C Web DX features work [1] and I noticed this had no compat flags set. I don't know what the contemporary compat triage process is, apologies if I set wrong flag.

1. https://github.com/web-platform-dx/web-features

Comment 6

[Dennis Schubert [:denschub]]

webcompat-priority is for things where we have known active WebCompat breakage for, which I don't think is the case here (yet?).

I'll ni? Tom so he can set the parity flags and add to his tracking.