Turn mozilla-config.h and js-confdefs.h into CONFIGURE_DEFINE_FILES

RESOLVED FIXED in Firefox 46

Status

Firefox Build System
General
RESOLVED FIXED
2 years ago
2 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla46
Dependency tree / graph

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
Created attachment 8696935 [details] [diff] [review]
Turn mozilla-config.h and js-confdefs.h into CONFIGURE_DEFINE_FILES

Both these files, are, after all, define files, like other CONFIGURE_DEFINE_FILES.
They only happen to have a special requirement for an expansion for all defines,
which doesn't need to happen through traditional preprocessing.

This change adds consistency in how configure-related headers are being handled.
Attachment #8696935 - Flags: review?(gps)
(Assignee)

Updated

2 years ago
Blocks: 1231315

Comment 2

2 years ago
Comment on attachment 8696935 [details] [diff] [review]
Turn mozilla-config.h and js-confdefs.h into CONFIGURE_DEFINE_FILES

Review of attachment 8696935 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/js-confdefs.h.in
@@ +5,5 @@
>  
>  #ifndef js_confdefs_h
>  #define js_confdefs_h
>  
> +#undef ALLDEFINES

Let's document that this behavior is special.
Attachment #8696935 - Flags: review?(gps) → review+

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3033ec8d8b3a
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Blocks: 1233282

Updated

2 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.