Closed
Bug 1231314
Opened 8 years ago
Closed 8 years ago
Turn mozilla-config.h and js-confdefs.h into CONFIGURE_DEFINE_FILES
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox46 fixed)
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
12.50 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Both these files, are, after all, define files, like other CONFIGURE_DEFINE_FILES. They only happen to have a special requirement for an expansion for all defines, which doesn't need to happen through traditional preprocessing. This change adds consistency in how configure-related headers are being handled.
Attachment #8696935 -
Flags: review?(gps)
Comment 2•8 years ago
|
||
Comment on attachment 8696935 [details] [diff] [review] Turn mozilla-config.h and js-confdefs.h into CONFIGURE_DEFINE_FILES Review of attachment 8696935 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/js-confdefs.h.in @@ +5,5 @@ > > #ifndef js_confdefs_h > #define js_confdefs_h > > +#undef ALLDEFINES Let's document that this behavior is special.
Attachment #8696935 -
Flags: review?(gps) → review+
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3033ec8d8b3a
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•