Status

RESOLVED FIXED
3 years ago
6 months ago

People

(Reporter: catlee, Assigned: catlee)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Assignee)

Description

3 years ago
We're going to kill off jacuzzis. This bug tracks work involved.
Created attachment 8697003 [details] [diff] [review]
bb-configs.diff
Attachment #8697003 - Flags: review?(catlee)
(Assignee)

Comment 2

3 years ago
Created attachment 8697005 [details] [diff] [review]
remove jacuzzis from buildbotcustom
Attachment #8697005 - Flags: review?(rail)
(Assignee)

Updated

3 years ago
Attachment #8697003 - Flags: review?(catlee) → review+
Created attachment 8697007 [details] [diff] [review]
[slave_health] v1

callek@Centaurus:~/mozilla/hg/slave_health$ hg diff --stat
 .hgignore               |    3 -
 css/slave_health.css    |   28 ++----
 index.html              |    2 +-
 jacuzzis.html           |  376 ++--------------------------------------------------------------------------------------------
 js/slave_health.js      |  154 --------------------------------------
 scripts/slave_health.py |    1 -
 slave.html              |    7 -
 slavetype.html          |    2 +-
 8 files changed, 21 insertions(+), 552 deletions(-)
Attachment #8697007 - Flags: review?(coop)
Attachment #8697005 - Flags: review?(rail) → review+
(Assignee)

Updated

3 years ago
Attachment #8697005 - Flags: checked-in+
Comment on attachment 8697007 [details] [diff] [review]
[slave_health] v1

Review of attachment 8697007 [details] [diff] [review]:
-----------------------------------------------------------------

::: jacuzzis.html
@@ +1,3 @@
>  <html>
> +  <head>
> +    <title>The Tudors</title>

Huh?

::: scripts/slave_health.py
@@ +372,1 @@
>                  if slave_types["all_slaves"].has_key(slave_name):

Do we still need all_slaves at all?
Attachment #8697007 - Flags: review?(coop) → review+
(In reply to Chris Cooper [:coop] from comment #6)
> Comment on attachment 8697007 [details] [diff] [review]
> [slave_health] v1
> 
> Review of attachment 8697007 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: jacuzzis.html
> @@ +1,3 @@
> >  <html>
> > +  <head>
> > +    <title>The Tudors</title>
> 
> Huh?

Haha, copy/paste fail (from a meta redirect example I found online). I just fixed.

> ::: scripts/slave_health.py
> @@ +372,1 @@
> >                  if slave_types["all_slaves"].has_key(slave_name):
> 
> Do we still need all_slaves at all?

Honestly, not sure. I *think* something else (outside of slave health) uses it, but I didn't want to gamble atm and just leave it in for now. We can remove and risk it though, at your (or others) discretion.


Pushed the existing patch (+ title fix) with: https://hg.mozilla.org/build/slave_health/rev/a5715dfec263
(Assignee)

Comment 8

3 years ago
Created attachment 8697030 [details] [diff] [review]
dejacuzzi-puppet.diff

Remove jacuzzi support in puppet. I'm not sure where this file actually gets used...
Attachment #8697030 - Flags: review?(rail)
Comment on attachment 8697030 [details] [diff] [review]
dejacuzzi-puppet.diff

Review of attachment 8697030 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #8697030 - Flags: review?(rail) → review+
(Assignee)

Comment 10

3 years ago
Just realized we may have to do something to keep thunderbird l10n jobs from consuming the OSX build pool in the morning
(Assignee)

Updated

3 years ago
Attachment #8697030 - Flags: checked-in+
(Assignee)

Updated

3 years ago
Assignee: nobody → catlee
(Assignee)

Comment 14

3 years ago
Dustin, I need some help disabling this on relengwebadm.private.scl3. Ideally we disable the cronjob, wait a few days, and then remove everything. Is that hard to do?
Flags: needinfo?(dustin)
I removed the cronjob from puppet and then manually deleted it.
Flags: needinfo?(dustin)
(Assignee)

Comment 16

3 years ago
No ill effects detected. Can we purge the jacuzzi stuff from relengwebadm.private.scl3 now?
Flags: needinfo?(dustin)
OK, I moved /data/releng/src/jacuzzi-allocator{,.disabled}, deleted the CNAME, and removed all puppet config for the site.
Flags: needinfo?(dustin)
(Assignee)

Comment 18

3 years ago
I think we're done here?
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Component: General Automation → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.