Closed
Bug 1231367
Opened 10 years ago
Closed 10 years ago
Kill Jacuzzis
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: catlee, Assigned: catlee)
Details
Attachments
(4 files)
|
3.50 KB,
patch
|
catlee
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
|
11.64 KB,
patch
|
rail
:
review+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
|
29.92 KB,
patch
|
coop
:
review+
|
Details | Diff | Splinter Review |
|
14.46 KB,
patch
|
rail
:
review+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
We're going to kill off jacuzzis. This bug tracks work involved.
Comment 1•10 years ago
|
||
Attachment #8697003 -
Flags: review?(catlee)
| Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8697005 -
Flags: review?(rail)
| Assignee | ||
Updated•10 years ago
|
Attachment #8697003 -
Flags: review?(catlee) → review+
Comment 3•10 years ago
|
||
callek@Centaurus:~/mozilla/hg/slave_health$ hg diff --stat
.hgignore | 3 -
css/slave_health.css | 28 ++----
index.html | 2 +-
jacuzzis.html | 376 ++--------------------------------------------------------------------------------------------
js/slave_health.js | 154 --------------------------------------
scripts/slave_health.py | 1 -
slave.html | 7 -
slavetype.html | 2 +-
8 files changed, 21 insertions(+), 552 deletions(-)
Attachment #8697007 -
Flags: review?(coop)
Comment 4•10 years ago
|
||
Comment on attachment 8697003 [details] [diff] [review]
bb-configs.diff
https://hg.mozilla.org/build/buildbot-configs/rev/7afa11c67780
Attachment #8697003 -
Flags: checked-in+
Updated•10 years ago
|
Attachment #8697005 -
Flags: review?(rail) → review+
| Assignee | ||
Comment 5•10 years ago
|
||
| Assignee | ||
Updated•10 years ago
|
Attachment #8697005 -
Flags: checked-in+
Comment 6•10 years ago
|
||
Comment on attachment 8697007 [details] [diff] [review]
[slave_health] v1
Review of attachment 8697007 [details] [diff] [review]:
-----------------------------------------------------------------
::: jacuzzis.html
@@ +1,3 @@
> <html>
> + <head>
> + <title>The Tudors</title>
Huh?
::: scripts/slave_health.py
@@ +372,1 @@
> if slave_types["all_slaves"].has_key(slave_name):
Do we still need all_slaves at all?
Attachment #8697007 -
Flags: review?(coop) → review+
Comment 7•10 years ago
|
||
(In reply to Chris Cooper [:coop] from comment #6)
> Comment on attachment 8697007 [details] [diff] [review]
> [slave_health] v1
>
> Review of attachment 8697007 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: jacuzzis.html
> @@ +1,3 @@
> > <html>
> > + <head>
> > + <title>The Tudors</title>
>
> Huh?
Haha, copy/paste fail (from a meta redirect example I found online). I just fixed.
> ::: scripts/slave_health.py
> @@ +372,1 @@
> > if slave_types["all_slaves"].has_key(slave_name):
>
> Do we still need all_slaves at all?
Honestly, not sure. I *think* something else (outside of slave health) uses it, but I didn't want to gamble atm and just leave it in for now. We can remove and risk it though, at your (or others) discretion.
Pushed the existing patch (+ title fix) with: https://hg.mozilla.org/build/slave_health/rev/a5715dfec263
| Assignee | ||
Comment 8•10 years ago
|
||
Remove jacuzzi support in puppet. I'm not sure where this file actually gets used...
Attachment #8697030 -
Flags: review?(rail)
Comment 9•10 years ago
|
||
Comment on attachment 8697030 [details] [diff] [review]
dejacuzzi-puppet.diff
Review of attachment 8697030 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm
Attachment #8697030 -
Flags: review?(rail) → review+
| Assignee | ||
Comment 10•10 years ago
|
||
Just realized we may have to do something to keep thunderbird l10n jobs from consuming the OSX build pool in the morning
| Assignee | ||
Comment 11•10 years ago
|
||
https://hg.mozilla.org/build/puppet/rev/55865d2cb8e7db4bdaf81e63db2da3f4a4f7b543
Bug 1231367: Kill jacuzzis r=rail
| Assignee | ||
Updated•10 years ago
|
Attachment #8697030 -
Flags: checked-in+
| Assignee | ||
Comment 12•10 years ago
|
||
https://hg.mozilla.org/build/puppet/rev/141ec903cfb93d154a73bb0d77476105188a8811
Bug 1231367: Only disable jacuzzi service on linux. r=rail
| Assignee | ||
Comment 13•10 years ago
|
||
| Assignee | ||
Updated•10 years ago
|
Assignee: nobody → catlee
| Assignee | ||
Comment 14•10 years ago
|
||
Dustin, I need some help disabling this on relengwebadm.private.scl3. Ideally we disable the cronjob, wait a few days, and then remove everything. Is that hard to do?
Flags: needinfo?(dustin)
Comment 15•10 years ago
|
||
I removed the cronjob from puppet and then manually deleted it.
Flags: needinfo?(dustin)
| Assignee | ||
Comment 16•10 years ago
|
||
No ill effects detected. Can we purge the jacuzzi stuff from relengwebadm.private.scl3 now?
Flags: needinfo?(dustin)
Comment 17•10 years ago
|
||
OK, I moved /data/releng/src/jacuzzi-allocator{,.disabled}, deleted the CNAME, and removed all puppet config for the site.
Flags: needinfo?(dustin)
| Assignee | ||
Comment 18•10 years ago
|
||
I think we're done here?
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•