Closed Bug 1231378 Opened 4 years ago Closed 4 years ago

Fix uninitialized members of classes - patches ready to land

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox45 --- wontfix
firefox46 --- fixed

People

(Reporter: baku, Assigned: baku)

References

(Depends on 1 open bug)

Details

(Keywords: sec-other, Whiteboard: [post-critsmash-triage][adv-main46-])

Attachments

(5 files)

+++ This bug was initially created as a clone of Bug #1217756 +++

I split bug 1217756 in order to land some of the patches I pushed without having the clang-plugin patch ready.
These patches have been reviewed in the previous bug. smaug, are you OK with landing them?
Flags: needinfo?(bugs)
Summary: Fix uninitialized members of classes → Fix uninitialized members of classes - patches ready to land
Should be fine. Some of the changes may be a bit bogus if ctor calls Reset or some such, but this
is good practice anyhow.
Flags: needinfo?(bugs)
backed out all patches here and bustage follow up for ongoing bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=19653201&repo=mozilla-inbound
Flags: needinfo?(amarchesini)
Flags: needinfo?(amarchesini)
Group: dom-core-security → core-security-release
huh, this bug is to back patches out?  there is no history of the patches landing?

:baku, can you please explain and point me to when this originally landed and what was backed out.  With no history in this bug I cannot explore myself.  I am tracking down a performance regression.
Flags: needinfo?(amarchesini)
(In reply to Joel Maher (:jmaher) from comment #10)
> huh, this bug is to back patches out?  there is no history of the patches
> landing?

Not really. This bug is about landing all the patches as comment 9 shows. Here the push to m-i:

https://hg.mozilla.org/integration/mozilla-inbound/rev/72fbfd236d8b
https://hg.mozilla.org/integration/mozilla-inbound/rev/824b152131b6
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8a738e7b8ff
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f773a189557
https://hg.mozilla.org/integration/mozilla-inbound/rev/b44a63b7a981
Flags: needinfo?(amarchesini)
Flags: qe-verify-
Whiteboard: [post-critsmash-triage]
Whiteboard: [post-critsmash-triage] → [post-critsmash-triage][adv-main46-]
Blocks: 402352
Group: core-security-release
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.