Closed
Bug 1231468
Opened 10 years ago
Closed 10 years ago
Update esomin to use latest esprima and escodegen
Categories
(Firefox OS Graveyard :: Gaia::Build, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jrburke, Assigned: jrburke)
Details
Attachments
(1 external file)
l20n.js is using more ES6 features and the esprima and escodegen AST tooling dependencies need to be updated to the latest versions to properly process the new syntax. Have a patch ready to go, just need to do the pull request/bug setup.
Comment 1•10 years ago
|
||
| Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8697051 [details] [review]
[gaia] jrburke:bug1231468-esomin-update > mozilla-b2g:master
Confirmed locally that this fixes being able to minify l20n.js.
Attachment #8697051 -
Flags: review?(rchien)
Comment 3•10 years ago
|
||
Confirmed locally that this fixes l20n.js as well.
Comment 4•10 years ago
|
||
Comment on attachment 8697051 [details] [review]
[gaia] jrburke:bug1231468-esomin-update > mozilla-b2g:master
LGTM.
Attachment #8697051 -
Flags: review?(rchien) → review+
| Assignee | ||
Comment 5•10 years ago
|
||
Merged in gaia master:
https://github.com/mozilla-b2g/gaia/commit/d886e152b42e557db612470d3417fe2947cbdeee
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•