Closed Bug 1231468 Opened 10 years ago Closed 10 years ago

Update esomin to use latest esprima and escodegen

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jrburke, Assigned: jrburke)

Details

Attachments

(1 external file)

l20n.js is using more ES6 features and the esprima and escodegen AST tooling dependencies need to be updated to the latest versions to properly process the new syntax. Have a patch ready to go, just need to do the pull request/bug setup.
Comment on attachment 8697051 [details] [review] [gaia] jrburke:bug1231468-esomin-update > mozilla-b2g:master Confirmed locally that this fixes being able to minify l20n.js.
Attachment #8697051 - Flags: review?(rchien)
Confirmed locally that this fixes l20n.js as well.
Comment on attachment 8697051 [details] [review] [gaia] jrburke:bug1231468-esomin-update > mozilla-b2g:master LGTM.
Attachment #8697051 - Flags: review?(rchien) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: