1231553 - Inset shadow makes most of the notification bar dark

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Ed Lee :Mardak]

Attachment: dec 7, dec 8 builds

Bug 1227216 was recently fixed which was causing some shadow oddness since november 22.

Bug 1214214 landed while the graphics bug existed, so the inset border appeared okay.

I've attached screenshots of builds from dec 7 (graphics bug not fixed) and dec 8 (graphics fixed).

Comment 1

[Mason Chang [Inactive] [:mchang]]

I'm confused, does that mean this bug is fixed since bug 1227216? Thanks!

Comment 2

[Ed Lee :Mardak]

No, this bug exists because it relied on the regressed behavior that was correctly fixed by bug 1227216.

I believe bug 1214214 didn't actually want a 40px inset box shadow.

Comment 3

[Manuel Casas Barrado [:mancas]]

Attachment: Inset shadow makes most of the notification bar dark

Comment 4

[Mike de Boer [:mikedeboer]]

Comment on attachment 8697272 [details] [diff] [review]
Inset shadow makes most of the notification bar dark

Review of attachment 8697272 [details] [diff] [review]:
-----------------------------------------------------------------

Looking good! Thanks for the demo :)

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2fb798379b16

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/2fb798379b16