1231557 - Audio and video elements don't use the URL classifier

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[François Marier [:francois]]

Because the audio and video elements open a channel without the nsIChannel::LOAD_CLASSIFY_URI loadflag, the tracking protection list doesn't apply to them.

Comment 1

[François Marier [:francois]]

Attachment: bug1231557.patch

This patch works, but I'm not sure we need to classify the channel in those three call sites. The dom/html/HTMLMediaElement one seems to be the only one that matters.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8697239 [details] [diff] [review]
bug1231557.patch

Review of attachment 8697239 [details] [diff] [review]:
-----------------------------------------------------------------

I think we're better off adding the flag to all of our call sites, otherwise a site could load a video to a URL that on first load that doesn't track, and then seek the video, causing us to hit the recreate-channel path, which the server could redirect to a URL which *does* track.

Comment 3

[François Marier [:francois]]

Attachment: bug1231557.patch

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/738a06a25a9b

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/738a06a25a9b