Closed Bug 1231633 Opened 4 years ago Closed 4 years ago
[Static Analysis][Uninitialized scalar field] Function ns
Doc Shell Load Info from ns Doc Shell Load Info .cpp
The Static Analysis tool Coverity added that variable member mLoadReplace is not attributed a value in the constructor: nsDocShellLoadInfo::nsDocShellLoadInfo() Most likely this is not a bug looking through code but i think we should still give it an ivitial value (false), as the rest of the scalar have.
Comment on attachment 8697233 [details] [diff] [review] Bug 1231633.diff While you're here, do you mind moving mLoadReplace to right after mOwner? The current setup is just silly alignment-wise. r=me
Attachment #8697233 - Flags: review?(bzbarsky) → review+
Sure here are the changes. Setting it to checkin-needed.
Attachment #8697233 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.