Closed
Bug 1231633
Opened 8 years ago
Closed 8 years ago
[Static Analysis][Uninitialized scalar field] Function nsDocShellLoadInfo from nsDocShellLoadInfo.cpp
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: andi, Assigned: andi)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: CID 1325963)
Attachments
(1 file, 1 obsolete file)
1.46 KB,
patch
|
Details | Diff | Splinter Review |
The Static Analysis tool Coverity added that variable member mLoadReplace is not attributed a value in the constructor: nsDocShellLoadInfo::nsDocShellLoadInfo() Most likely this is not a bug looking through code but i think we should still give it an ivitial value (false), as the rest of the scalar have.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8697233 -
Flags: review?(bzbarsky)
Comment 2•8 years ago
|
||
Comment on attachment 8697233 [details] [diff] [review] Bug 1231633.diff While you're here, do you mind moving mLoadReplace to right after mOwner? The current setup is just silly alignment-wise. r=me
Attachment #8697233 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Sure here are the changes. Setting it to checkin-needed.
Attachment #8697233 -
Attachment is obsolete: true
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c25eae60b8d3
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•