Closed
Bug 1231665
Opened 9 years ago
Closed 9 years ago
"mach android-emulator" may not complete when a device is connected
Categories
(Testing :: General, defect)
Testing
General
Tracking
(firefox46 fixed)
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: gbrown, Assigned: gbrown)
Details
Attachments
(1 file)
1.26 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
With my Nexus 4 connected: $ ./mach android-emulator 0:00.21 Starting Android emulator running Android 4.3... The emulator is started, but the mach command does not complete. $ adb devices List of devices attached 016e01dbcd98f851 device emulator-5554 device
Assignee | ||
Comment 1•9 years ago
|
||
mach completes if I unplug the device.
Assignee | ||
Comment 2•9 years ago
|
||
The issue here is that wait_for_device is issuing adb commands to check for boot completion, but the commands are going to the connected phone instead of the emulator. Specifying deviceSerial in the emulator devicemanager instance rectifies the problem.
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8698023 -
Flags: review?(jmaher)
Comment 4•9 years ago
|
||
Comment on attachment 8698023 [details] [diff] [review] specify deviceSerial for emulator commands Review of attachment 8698023 [details] [diff] [review]: ----------------------------------------------------------------- good stuff!
Attachment #8698023 -
Flags: review?(jmaher) → review+
Comment 6•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7c790bfad7fe
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•