1231688 - Refactor AnimationPlayerActor's getDuration/Delay/... by using waapi's getComputedTiming

Status: RESOLVED FIXED

(DevTools :: Inspector: Animations, defect)

Description

[Patrick Brosset <:pbro>]

The WebAnimations API exposes a getComputedTiming function that we should use to get rid of CSS parsing in the AnimationPlayerActor.

Comment 1

[Patrick Brosset <:pbro>]

I think this is a simple enough bug, and the various automated tests we have should be a good safety net here.
Here is an example of getting timing information from the animation API:

let timing = element.getAnimations()[0].effect.getComputedTiming();

Using this should help us clean up AnimationPlayerActor a lot:
get rid of playerIndex and getPlayerIndex, and massively simplify getDuration, getDelay and getIterationCount.

If anyone is interested, this is a good code clean-up bug, I can mentor if needed.
The file where these changes are needed is \devtools\server\actors\animation.js

Comment 2

[Patrick Brosset <:pbro>]

Attachment: Bug_1231688_-_Use_waapi_computed_timing_in_devtool.diff

Ended up taking this bug as we'll need these changes sooner rather than later.

Comment 3

[Patrick Brosset <:pbro>]

Comment on attachment 8700554 [details] [diff] [review]
Bug_1231688_-_Use_waapi_computed_timing_in_devtool.diff

https://treeherder.mozilla.org/#/jobs?repo=try&revision=28c5819e89d7

Comment 4

[Tom Tromey :tromey]

Comment on attachment 8700554 [details] [diff] [review]
Bug_1231688_-_Use_waapi_computed_timing_in_devtool.diff

Review of attachment 8700554 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  Nice cleanup!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/1962dad1f211

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1962dad1f211

Comment 7

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel	        beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected