Closed Bug 1231772 Opened 5 years ago Closed 5 months ago
Live Samples that need attention
Ok, it looks like these are mostly wrong parameters to EmbedLiveSample. Just fixed the first one (/en-US/docs/Web/API/EventTarget/addEventListener ) that covers about 20% of all events.
Just to record progress: we are at 584 errors.
Stephanie, I can't find a problem with these pages (I checked these over 4-5 days). I never saw them with a live sample missing and they consistently appear in the list of errors. Could you investigate what can cause this false positives? (There are likely more in the remaining results).
I had a look at the false positives and I can't see anything wrong either :/ I'll have a better look but it might not be until I'm back from PTO on the 7th.
PeriodicSyncEvent and SyncEvent are using the InheritanceDiagram macro which draws an iframe with an SVG in it?!?! The iframe has the same classes as a live sample on it so the script which creates the live samples tries to add the buttons to the bottom of this macro and fails. Probably we should have a discussion about what is trying to be accomplished here and what is needed. The SVG becomes unreadable on smaller screen sizes even though it has the space to remain readable on some of the pages where it is used (PeriodicSyncEvent for example though less so on InstallEvent). The same affect could probably be achieved with CSS and then we could have some media queries to make the diagram vertical on smaller screens.
I think the problem on the CSS gradient page is that the code is expecting the samples to be separated by headings. I'll see if it's possible to modify it to look for <li>s as well.
I've poked at the ajax errors and am not able to reproduce but I was able to confirm that they're happening very infrequently on samples. I'm going to try to improve the error messages to help diagnose but that will take a week or so to get into production and start feeding us data.
Er, infrequently on samples that are otherwise fine.
MDN Web Docs' bug reporting has now moved to GitHub. From now on, please file content bugs at https://github.com/mdn/sprints/issues/ and platform bugs at https://github.com/mdn/kuma/issues/.
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.