Closed
Bug 1231798
Opened 9 years ago
Closed 9 years ago
Intermittent TEST-UNEXPECTED-TIMEOUT | /custom-elements/custom-element-lifecycle/types-of-callbacks/attribute-changed-callback-change-attribute-test.html | expected OK
Categories
(Testing :: web-platform-tests, defect)
Testing
web-platform-tests
Tracking
(firefox45 fixed, firefox46 fixed)
RESOLVED
FIXED
mozilla46
People
(Reporter: philor, Assigned: bkelly)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
Comment hidden (Intermittent Failures Robot) |
Flags: needinfo?(james)
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 4•9 years ago
|
||
This seems to be mostly happening since disabling attached-callback-move-element-test.html in https://hg.mozilla.org/integration/mozilla-inbound/rev/8dd58892051a
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=platform%20%281%29%20opt%20linux&tochange=707a87454058&fromchange=a1caa7e7949f&selectedJob=18447654
I suspect we've just moved the intermittent from one test to another.
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 6•9 years ago
|
||
After talking with James and William, I am going to disable all the custom-element wpt tests. We have an impl, but its behind a pref. I will file a follow-up bug to investigate the tests and re-enable.
Assignee | ||
Comment 7•9 years ago
|
||
Assignee: nobody → bkelly
Status: NEW → ASSIGNED
Flags: needinfo?(james)
Attachment #8701560 -
Flags: review?(james)
Comment 8•9 years ago
|
||
Comment on attachment 8701560 [details] [diff] [review]
Mass disable custom-elements wpt tests since they are not actually testing anything currently. r=jgraham
Review of attachment 8701560 [details] [diff] [review]:
-----------------------------------------------------------------
But there is an easier way; it should also work to just put a __dir__.ini under /custom-elements/ and I would have left all the metadata files in as a reference for when we reenable the tests.
Attachment #8701560 -
Flags: review?(james) → review+
Assignee | ||
Comment 9•9 years ago
|
||
(In reply to James Graham [:jgraham] from comment #8)
> But there is an easier way; it should also work to just put a __dir__.ini
> under /custom-elements/ and I would have left all the metadata files in as a
> reference for when we reenable the tests.
I've seen the recursion of __dir__.ini not work on some platforms. Maybe thats fixed, but I didn't have time to try a lot of different things today.
And I removed the other metadata because it should all be different with the dom.webcomponents.enabled pref turned on. All new metadata will have to be figured out.
Thanks for the review. Have a great holiday.
Comment 10•9 years ago
|
||
Comment hidden (Intermittent Failures Robot) |
Comment 12•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Comment hidden (Intermittent Failures Robot) |
Comment 14•9 years ago
|
||
bugherder uplift |
status-firefox45:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•