1231832 - Deleting queries can crash if they haven't been used.

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Make IsActive work on Querys that have not begun.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8697577 [details] [diff] [review]
Make IsActive work on Querys that have not begun.

Review of attachment 8697577 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLQuery.cpp
@@ +45,5 @@
>  
> +        return targetSlot.get() == this;
> +    } else {
> +        return false;
> +    }

We generally prefer:
if (!HasEverBeenActive())
  return false;
...

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/761059d108fc

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/761059d108fc