Closed
Bug 1231832
Opened 8 years ago
Closed 8 years ago
Deleting queries can crash if they haven't been used.
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: jrmuizel)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
1.75 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8697577 -
Flags: review?(jgilbert)
Comment 2•8 years ago
|
||
Comment on attachment 8697577 [details] [diff] [review] Make IsActive work on Querys that have not begun. Review of attachment 8697577 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/canvas/WebGLQuery.cpp @@ +45,5 @@ > > + return targetSlot.get() == this; > + } else { > + return false; > + } We generally prefer: if (!HasEverBeenActive()) return false; ...
Attachment #8697577 -
Flags: review?(jgilbert) → review+
Updated•8 years ago
|
Whiteboard: [gfx-noted]
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/761059d108fc
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Updated•8 years ago
|
Assignee: nobody → jmuizelaar
You need to log in
before you can comment on or make changes to this bug.
Description
•