[ja] New mapping services for SeaMonkey

RESOLVED FIXED

Status

Mozilla Localizations
ja / Japanese
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: marsf, Assigned: marsf)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
Created attachment 8697458 [details] [diff] [review]
sm2.41 map service patch

A patch related to bug 531285 for ja locales.

I changed the default "mail.addr_book.mapit_url.format" to make same with Thunderbird, as well as other parameters.
(Assignee)

Updated

2 years ago
Assignee: nobody → chimantaea_mirabilis
Depends on: 531285
(Assignee)

Updated

2 years ago
Attachment #8697458 - Flags: review?(bugspam.Callek)
(Assignee)

Comment 1

2 years ago
> same with Thunderbird

Please see bug 1231859.
Comment on attachment 8697458 [details] [diff] [review]
sm2.41 map service patch

Review of attachment 8697458 [details] [diff] [review]:
-----------------------------------------------------------------

Sadly, I won't be able to review this for a week+. So I'm redirecting to Ian who should be able to address it faster and has reviewed a similar patch elsewhere already.
Attachment #8697458 - Flags: review?(bugspam.Callek) → review?(iann_bugzilla)

Comment 3

2 years ago
Comment on attachment 8697458 [details] [diff] [review]
sm2.41 map service patch

>+mail.addr_book.mapit_url.format=http://maps.google.co.jp/maps?q=@CO@ST@CI@A1@A2

>+mail.addr_book.mapit_url.1.format=http://maps.google.co.jp/maps?q=@CO%20@ST@CI@A1@A2%20@ZI
Shouldn't these two URLs match?

The other thing I noticed is that all other locales use %20 as a separator between arguments. Is maps.google.co.jp a special case?
Flags: needinfo?(chimantaea_mirabilis)
(Assignee)

Comment 4

2 years ago
(In reply to Ian Neal from comment #3)
> Shouldn't these two URLs match?

It should be.

> The other thing I noticed is that all other locales use %20 as a separator
> between arguments. Is maps.google.co.jp a special case?

The parameter without %20 works only for the place in Japan.
This is our mistake and it doesn't work for foreign countries.
Flags: needinfo?(chimantaea_mirabilis)
(Assignee)

Comment 5

2 years ago
Created attachment 8699281 [details] [diff] [review]
sm2.41 map service patch 2

Revised.
Attachment #8697458 - Attachment is obsolete: true
Attachment #8697458 - Flags: review?(iann_bugzilla)
Attachment #8699281 - Flags: review?(iann_bugzilla)

Comment 6

2 years ago
Comment on attachment 8699281 [details] [diff] [review]
sm2.41 map service patch 2

Looks good, thanks.
Attachment #8699281 - Flags: review?(iann_bugzilla) → review+
You need to log in before you can comment on or make changes to this bug.