1231862 - [ja] New mapping services for SeaMonkey

Status: RESOLVED FIXED

(Mozilla Localizations :: ja / Japanese, defect)

Description

[Masahiko Imanaka [:marsf]]

Attachment: sm2.41 map service patch

A patch related to bug 531285 for ja locales.

I changed the default "mail.addr_book.mapit_url.format" to make same with Thunderbird, as well as other parameters.

Comment 1

[Masahiko Imanaka [:marsf]]

> same with Thunderbird

Please see bug 1231859.

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 8697458 [details] [diff] [review]
sm2.41 map service patch

Review of attachment 8697458 [details] [diff] [review]:
-----------------------------------------------------------------

Sadly, I won't be able to review this for a week+. So I'm redirecting to Ian who should be able to address it faster and has reviewed a similar patch elsewhere already.

Comment 3

[Ian Neal]

Comment on attachment 8697458 [details] [diff] [review]
sm2.41 map service patch

>+mail.addr_book.mapit_url.format=http://maps.google.co.jp/maps?q=@CO@ST@CI@A1@A2

>+mail.addr_book.mapit_url.1.format=http://maps.google.co.jp/maps?q=@CO%20@ST@CI@A1@A2%20@ZI
Shouldn't these two URLs match?

The other thing I noticed is that all other locales use %20 as a separator between arguments. Is maps.google.co.jp a special case?

Comment 4

[Masahiko Imanaka [:marsf]]

(In reply to Ian Neal from comment #3)
> Shouldn't these two URLs match?

It should be.

> The other thing I noticed is that all other locales use %20 as a separator
> between arguments. Is maps.google.co.jp a special case?

The parameter without %20 works only for the place in Japan.
This is our mistake and it doesn't work for foreign countries.

Comment 5

[Masahiko Imanaka [:marsf]]

Attachment: sm2.41 map service patch 2

Revised.

Comment 6

[Ian Neal]

Comment on attachment 8699281 [details] [diff] [review]
sm2.41 map service patch 2

Looks good, thanks.

Comment 7

[Masahiko Imanaka [:marsf]]

Thanks!

aurora:
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/rev/ac29c8c89099
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja-JP-mac/rev/23832282d55f

beta:
http://hg.mozilla.org/releases/l10n/mozilla-beta/ja/rev/47e9100adbf9
http://hg.mozilla.org/releases/l10n/mozilla-beta/ja-JP-mac/rev/cf8465495e14