Remove NativeSurfaceType::CAIRO_SURFACE

RESOLVED FIXED in Firefox 46

Status

()

Core
Graphics
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla46
Points:
---

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
We have both NativeSurfaceType::CAIRO_CONTEXT and
NativeSurfaceType::CAIRO_SURFACE. They both refer to DrawTargets with Cairo
backends. The only reason for having both is so you can call GetNativeSurface()
and get either the |cairo_t*| or the underlying |cairo_surface_t*|.

I argue that this convenience confuses things more than it helps.
(Assignee)

Comment 1

3 years ago
Created attachment 8697476 [details] [diff] [review]
Remove NativeSurfaceType::CAIRO_SURFACE

This patch removes CAIRO_SURFACE, and adds explicit cairo_get_target() calls
where necessary.
Attachment #8697476 - Flags: review?(bas)
(Assignee)

Comment 2

3 years ago
Created attachment 8697483 [details] [diff] [review]
Remove NativeSurfaceType::CAIRO_SURFACE

(Fix Windows compile error.)
Attachment #8697483 - Flags: review?(bas)
(Assignee)

Updated

3 years ago
Attachment #8697476 - Attachment is obsolete: true
Attachment #8697476 - Flags: review?(bas)
Comment on attachment 8697483 [details] [diff] [review]
Remove NativeSurfaceType::CAIRO_SURFACE

Review of attachment 8697483 [details] [diff] [review]:
-----------------------------------------------------------------

I agree.
Attachment #8697483 - Flags: review?(bas) → review+

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0cd53e82df1f
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.