Closed
Bug 1231881
Opened 10 years ago
Closed 10 years ago
Remove NativeSurfaceType::CAIRO_SURFACE
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 file, 1 obsolete file)
|
11.35 KB,
patch
|
bas.schouten
:
review+
|
Details | Diff | Splinter Review |
We have both NativeSurfaceType::CAIRO_CONTEXT and
NativeSurfaceType::CAIRO_SURFACE. They both refer to DrawTargets with Cairo
backends. The only reason for having both is so you can call GetNativeSurface()
and get either the |cairo_t*| or the underlying |cairo_surface_t*|.
I argue that this convenience confuses things more than it helps.
|
Assignee | |
Comment 1•10 years ago
|
||
This patch removes CAIRO_SURFACE, and adds explicit cairo_get_target() calls
where necessary.
Attachment #8697476 -
Flags: review?(bas)
|
|
Assignee | |
Comment 2•10 years ago
|
||
(Fix Windows compile error.)
Attachment #8697483 -
Flags: review?(bas)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8697476 -
Attachment is obsolete: true
Attachment #8697476 -
Flags: review?(bas)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8697483 [details] [diff] [review]
Remove NativeSurfaceType::CAIRO_SURFACE
Review of attachment 8697483 [details] [diff] [review]:
-----------------------------------------------------------------
I agree.
Attachment #8697483 -
Flags: review?(bas) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0cd53e82df1fb5680cd61437fbea23989df4dee3
Bug 1231881 - Remove NativeSurfaceType::CAIRO_SURFACE. r=bas.
|
|
||
Comment 5•10 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•