1231899 - [meta] Investigate how we check the return value of JS_snprintf()

Status: RESOLVED INVALID

(Core :: JavaScript Engine, defect)

Description

[Wei Wu [:wuwei UTC+8]]

According to bug 1231581 comment 2, the document for JS_snprintf() is non-consistent with the code. I think we should investigate how we check the return value of JS_snprintf(), to make sure that we were not introducing any (security-related) bugs.

Comment 1

[Wei Wu [:wuwei UTC+8]]

Attachment: fix a JS_snprintf return value check in LCovRuntime

if the return value of JS_snprintf() equals the buffer size, something had gone wrong. The current fprintf is unreachable, iiuc.

Comment 2

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8697520 [details] [diff] [review]
fix a JS_snprintf return value check in LCovRuntime

Review of attachment 8697520 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks :)

Comment 3

[Carsten Book [:Tomcat]]

This failed to apply:

renamed 1231899 -> bug1231899p1.patch
applying bug1231899p1.patch
patching file js/src/vm/CodeCoverage.cpp
Hunk #1 FAILED at 467
1 out of 1 hunks FAILED -- saving rejects to file js/src/vm/CodeCoverage.cpp.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh bug1231899p1.patch

Comment 4

[Wei Wu [:wuwei UTC+8]]

(In reply to Carsten Book [:Tomcat] from comment #3)
> This failed to apply:
> 
> renamed 1231899 -> bug1231899p1.patch
> applying bug1231899p1.patch
> patching file js/src/vm/CodeCoverage.cpp
> Hunk #1 FAILED at 467
> 1 out of 1 hunks FAILED -- saving rejects to file
> js/src/vm/CodeCoverage.cpp.rej
> patch failed, unable to continue (try -v)
> patch failed, rejects left in working directory
> errors during apply, please fix and qrefresh bug1231899p1.patch

Ah, turns out this bug has been fixed by patches for bug 1219166, so the patch is no longer needed.
Sorry for inconvenience.

Comment 5

[Wei Wu [:wuwei UTC+8]]

Comment on attachment 8697520 [details] [diff] [review]
fix a JS_snprintf return value check in LCovRuntime

obsolete this patch, for this bug has been fixed by patches for bug 1219166.

Comment 6

[Tom Tromey :tromey]

JS_snprintf doesn't seem to exist any more, so perhaps this bug is obsolete now.

Comment 7

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.