1231931 - Split string files into add-on, shared, standalone files

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Ed Lee :Mardak]

Instead of duplicating strings in the two loop.properties files for the add-on and standalone, we can build those files from 3 files.

These should be the strings in common:

> chat_textbox_placeholder=Type here…
> clientShortname2=Firefox Hello
> conversation_has_ended=Your conversation has ended.
> generic_failure_message=We're having technical difficulties…
> generic_failure_no_reason2=Would you like to try again?
> help_label=Help
> mute_local_audio_button_title=Mute your audio
> mute_local_video_button_title2=Disable video
> retry_call_button=Retry
> rooms_leave_button_label=Leave
> rooms_panel_title=Choose a conversation or start a new one
> rooms_room_full_call_to_action_label=Learn more about {{clientShortname}} »
> rooms_room_full_call_to_action_nonFx_label=Download {{brandShortname}} to start your own
> rooms_room_full_label=There are already two people in this conversation.
> rooms_room_join_label=Join the conversation
> rooms_room_joined_label=Someone has joined the conversation!
> tos_failure_message={{clientShortname}} is not available in your country.
> unmute_local_audio_button_title=Unmute your audio
> unmute_local_video_button_title2=Enable video

Comment 1

[Ed Lee :Mardak]

We'll place the strings at locale/en-US/{add-on,shared,standalone}.properties

Then in the build process, we'll generate the loop.properties files needed by the add-on and standalone.

Comment 2

[Chris Rafuse :crafuse]

Attachment: Link to Github pull-request: https://github.com/mozilla/loop/pull/5

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8697582 [details] [review]
Link to Github pull-request: https://github.com/mozilla/loop/pull/5

I've put a couple of comments in the PR. Please re-request review once completed.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8697582 [details] [review]
Link to Github pull-request: https://github.com/mozilla/loop/pull/5

Looks good. One minor comment for the changeset commit message to address.

Comment 5

[Ed Lee :Mardak]

https://github.com/mozilla/loop/commit/4628886aac1f795f6871ae8144a2a61b99efe850

Comment 6

[Ed Lee :Mardak]

I noticed in bug 1238510 that this bug readded at least a couple strings:

-infobar_menuitem_dontshowagain_label=Don't show this again
-infobar_menuitem_dontshowagain_accesskey=D

Comment 7

[Ed Lee :Mardak]

Actually these too:

-infobar_button_gotit_label=Got it!
-infobar_button_gotit_accesskey=G