1231950 - Ship (or use Desktop Fx) Android ADB with mozregression

Status: NEW

(Testing :: mozregression, defect)

Description

[Kevin Brosnan [Ex-Mozilla]]

It would be nice to have adb available so that Android users can bisect without installing the Android SDK.

Would it be safe/easy to use Firefox desktop WebIDE install of adb? If not shipping the adb binary for Windows, OS X and/or Linux would be helpful.

Comment 1

[Arjen de Jager]

Because I would like to find a regression range for bug 1391430, I tried to get mozregression-gui working to run a bisection of fennec. After I installed Android Studio (https://developer.android.com/studio/index.html) and set the correct path (I followed the steps at https://www.androidcentral.com/installing-android-sdk-windows-mac-and-linux-tutorial), I didn't succeed. Restarting mozregression-gui and Windows didn't help.

I'm just a tester, not a developer and not very technically minded. I'm happy with the availability and ease of use of the gui version of mozregression. I would be very happy when could use mozregression-gui to test Firefox for Android even out of the box.

I would appreciate any help to get testing fennec with mozregression-gui working, also without this bug fixed. I spent quite some time to get it working already and not succeeding is pretty frustrating and somewhat demotivating.

Comment 2

[Arjen de Jager]

(In reply to Arjen de Jager from comment #1)
> I would appreciate any help to get testing fennec with mozregression-gui
> working, also without this bug fixed.

mozregression-gui Log view output:

2017-08-18T13:47:23: DEBUG : ADBHost: {'_logger': <mozlog.structuredlog.StructuredLogger object at 0x03DFBE70>, '_adb_version': '', '_adb_host': None, '_adb_port': None, '_timeout': 300, '_polling_interval': 0.1, '_adb_path': 'adb', '_verbose': False}

In case of any help.

Comment 3

[William Lachance (:wlach)]

We should probably bundle a windows executable of adb with mozregression-gui.

Arjen: your path likely isn't set up correctly. I'm actually not an expert on how Windows determines the path from applications, so I'm not sure if I can give detailed help here unfortunately. :( I will try to fix ^^ sometime in the near future.

Comment 4

[William Lachance (:wlach)]

Not working on this right now, probably still a good idea. Another alternative might be to use a pure-python adb alternative like adb shell: https://github.com/JeffLIrion/adb_shell -- but I couldn't get it working immediately in my testing

Comment 5

[Rob Wu [:robwu]]

Firefox's logic to download the adb binary is at:

• downloading xpi containing adb: https://searchfox.org/firefox-main/rev/a5d7b5634b073a6b9e0d9f0f7df163d10cba478b/devtools/client/shared/remote-debugging/adb/adb-addon.js
  • The URL of the xpi URL to download is taken from the devtools.remote.adb.extensionURL pref with #OS# replaced with the OS-specific part (source).
  • I wondered how stable the URL is; it was last changed 3 years ago in bug 1800985.
• The downloaded adb binary is used at: https://searchfox.org/firefox-main/rev/a5d7b5634b073a6b9e0d9f0f7df163d10cba478b/devtools/client/shared/remote-debugging/adb/adb-binary.js

adb is launched by mozregression via https://github.com/mozilla/mozregression/blob/1564c18dae4d726ea386e881d3fadb4624d99766/mozregression/launchers.py#L445-L454. By default, it launches adb (without absolute directory path, so whatever executable adb can be located from one of the items in PATH can be used): https://searchfox.org/firefox-main/rev/a5d7b5634b073a6b9e0d9f0f7df163d10cba478b/testing/mozbase/mozdevice/mozdevice/adb.py#398-402

To reuse Firefox's logic, the mozregression implementation would have to download the xpi like Firefox, extract the adb binary from it, and then override the adb parameter. This could be done conditionally, if there is no adb executable found in $PATH.