1231968 - Add BHR pseudo-stack for open/close tabs

Status: RESOLVED INVALID

(Toolkit :: Telemetry, defect)

Description

[Chris H-C :chutten]

Opening and closing tabs can really jank (for instance, hold Ctrl+T for a while to open a couple hundred tabs (observe jank) then close all other tabs (observe jank)).

We should have BHR coverage.

Comment 1

[Chris H-C :chutten]

Attachment: 0001-bug-1231986-Parameterize-SamplerStackFrameRAII-so-ca.patch

Some strings may not survive long enough for the sampler to use them. Plumb the "copy the string" parameter through the RAII so that it can take care of it.

Comment 2

[Chris H-C :chutten]

Attachment: 0002-bug-1231968-Expose-PROFILER_LABEL-to-JS.patch

Construct a JavaScript API that will act like the PROFILER_LABEL macro. It will annotate the stack and then call the provided function.

This will help us identify slow JS code in BHR pseudo-stacks.

Comment 3

[Benoit Girard (:BenWa)]

Comment on attachment 8715798 [details] [diff] [review]
0002-bug-1231968-Expose-PROFILER_LABEL-to-JS.patch

Review of attachment 8715798 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 4

[Chris H-C :chutten]

BHR already tracks JS frames using file:line information. Adding more code to do something that's already done is probably not helpful, so I'm going to drop this.