Closed Bug 1231973 Opened 5 years ago Closed 5 years ago
Hook the mtransport NAT simulator up to the pref system, to allow it to be used in browser testing
58 bytes, text/x-review-board-request
We should have a pref that, when set, causes each NrIceCtx to get a simulated NAT based on TestNrSocket. To facilitate testing where multiple PeerConnections get different kinds of NATs, this pref should take effect when a PeerConnection is created. (A possible alternative is to make this a proprietary parameter on PeerConnection, but this has more security implications)
Review commit: https://reviewboard.mozilla.org/r/29451/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/29451/
https://reviewboard.mozilla.org/r/29451/#review26989 ::: media/mtransport/nricectx.cpp:542 (Diff revision 1) > + MOZ_MTLOG(ML_DEBUG, "NAT filtering type: " << filtering_type); > + MOZ_MTLOG(ML_DEBUG, "NAT mapping type: " << mapping_type); As these settings are potentially pretty harmful can we make them somehow show up on about:webrtc?
https://reviewboard.mozilla.org/r/29451/#review26989 > As these settings are potentially pretty harmful can we make them somehow show up on about:webrtc? That's not a bad idea, I suppose.
Comment on attachment 8703719 [details] MozReview Request: Bug 1231973: Allow NAT simulator to be enabled with the pref system. r?drno Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29451/diff/1-2/
Comment on attachment 8703719 [details] MozReview Request: Bug 1231973: Allow NAT simulator to be enabled with the pref system. r?drno https://reviewboard.mozilla.org/r/29451/#review29901 LGTM
Attachment #8703719 - Flags: review?(drno) → review+
You need to log in before you can comment on or make changes to this bug.