bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.
Please report any other irregularities here.
Hook the mtransport NAT simulator up to the pref system, to allow it to be used in browser testing
RESOLVED
FIXED
in Firefox 47
Status
()
People
(Reporter: bwc, Assigned: bwc)
Tracking
Firefox Tracking Flags
(firefox45 affected, firefox47 fixed)
Details
MozReview Requests
()
| Submitter | Diff | Changes | Open Issues | Last Updated |
|---|---|---|---|---|
| Loading... | ||||
| Error loading review requests: | ||||
Attachments
(1 attachment)
We should have a pref that, when set, causes each NrIceCtx to get a simulated NAT based on TestNrSocket. To facilitate testing where multiple PeerConnections get different kinds of NATs, this pref should take effect when a PeerConnection is created. (A possible alternative is to make this a proprietary parameter on PeerConnection, but this has more security implications)
|
(Assignee) | |
Updated•3 years ago
|
||
Priority: -- → P1
|
||
Updated•3 years ago
|
||
Rank: 15
|
|
(Assignee) | |
Comment 1•3 years ago
|
||
Created attachment 8703719 [details] MozReview Request: Bug 1231973: Allow NAT simulator to be enabled with the pref system. r?drno Review commit: https://reviewboard.mozilla.org/r/29451/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/29451/
|
||
Comment 2•3 years ago
|
||
https://reviewboard.mozilla.org/r/29451/#review26989 ::: media/mtransport/nricectx.cpp:542 (Diff revision 1) > + MOZ_MTLOG(ML_DEBUG, "NAT filtering type: " << filtering_type); > + MOZ_MTLOG(ML_DEBUG, "NAT mapping type: " << mapping_type); As these settings are potentially pretty harmful can we make them somehow show up on about:webrtc?
|
|
(Assignee) | |
Comment 3•3 years ago
|
||
https://reviewboard.mozilla.org/r/29451/#review26989 > As these settings are potentially pretty harmful can we make them somehow show up on about:webrtc? That's not a bad idea, I suppose.
|
|
(Assignee) | |
Comment 4•3 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c1324723aa2
|
|
(Assignee) | |
Comment 5•3 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=168148cef3d1
|
|
(Assignee) | |
Comment 6•3 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d53ef39d6b03
|
|
(Assignee) | |
Comment 7•3 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d343ae7f402c
|
|
(Assignee) | |
Updated•3 years ago
|
||
Attachment #8703719 -
Attachment description: MozReview Request: Bug 1231973: (WIP) Allow NAT simulator to be enabled with the pref system. → MozReview Request: Bug 1231973: Allow NAT simulator to be enabled with the pref system. r?drno
Attachment #8703719 -
Flags: review?(drno)
|
|
(Assignee) | |
Comment 8•3 years ago
|
||
Comment on attachment 8703719 [details] MozReview Request: Bug 1231973: Allow NAT simulator to be enabled with the pref system. r?drno Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29451/diff/1-2/
|
|
||
Comment 9•3 years ago
|
||
Comment on attachment 8703719 [details] MozReview Request: Bug 1231973: Allow NAT simulator to be enabled with the pref system. r?drno https://reviewboard.mozilla.org/r/29451/#review29901 LGTM
Attachment #8703719 -
Flags: review?(drno) → review+
|
|
(Assignee) | |
Updated•3 years ago
|
||
Assignee: nobody → docfaraday
|
|
(Assignee) | |
Updated•3 years ago
|
||
Keywords: checkin-needed
|
||
Comment 10•3 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7813b3eee97
Keywords: checkin-needed
|
||
Comment 11•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c7813b3eee97
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•