1231973 - Hook the mtransport NAT simulator up to the pref system, to allow it to be used in browser testing

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P1)

Description

[Byron Campen [:bwc]]

We should have a pref that, when set, causes each NrIceCtx to get a simulated NAT based on TestNrSocket. To facilitate testing where multiple PeerConnections get different kinds of NATs, this pref should take effect when a PeerConnection is created.

(A possible alternative is to make this a proprietary parameter on PeerConnection, but this has more security implications)

Comment 1

[Byron Campen [:bwc]]

Attachment: MozReview Request: Bug 1231973: Allow NAT simulator to be enabled with the pref system. r?drno

Review commit: https://reviewboard.mozilla.org/r/29451/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29451/

Comment 2

[Nils Ohlmeier [:drno]]

https://reviewboard.mozilla.org/r/29451/#review26989

::: media/mtransport/nricectx.cpp:542
(Diff revision 1)
> +  MOZ_MTLOG(ML_DEBUG, "NAT filtering type: " << filtering_type);
> +  MOZ_MTLOG(ML_DEBUG, "NAT mapping type: " << mapping_type);

As these settings are potentially pretty harmful can we make them somehow show up on about:webrtc?

Comment 3

[Byron Campen [:bwc]]

https://reviewboard.mozilla.org/r/29451/#review26989

> As these settings are potentially pretty harmful can we make them somehow show up on about:webrtc?

That's not a bad idea, I suppose.

Comment 4

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c1324723aa2

Comment 5

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=168148cef3d1

Comment 6

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d53ef39d6b03

Comment 7

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d343ae7f402c

Comment 8

[Byron Campen [:bwc]]

Comment on attachment 8703719 [details]
MozReview Request: Bug 1231973: Allow NAT simulator to be enabled with the pref system. r?drno

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29451/diff/1-2/

Comment 9

[Nils Ohlmeier [:drno]]

Comment on attachment 8703719 [details]
MozReview Request: Bug 1231973: Allow NAT simulator to be enabled with the pref system. r?drno

https://reviewboard.mozilla.org/r/29451/#review29901

LGTM

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c7813b3eee97

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c7813b3eee97