1231984 - Add-on SDK tabs problem: domWindow.gBrowserInit is undefined

Status: RESOLVED FIXED

(SeaMonkey :: Tabbed Browser, defect)

Description

[Per Johansson]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:42.0) Gecko/20100101 Firefox/42.0
Build ID: 20151029151421

Steps to reproduce:

Steps to reproduce:

Started SeaMonkey 2.42a1 Build identifier: 20151210003002 with my extension DCC enabled.

https://addons.mozilla.org/seamonkey/addon/direct-currency-converter-2-fo/



Actual results:

Error:

console.error: direct-currency-converter-2-sm: 
  Message: TypeError: domWindow.gBrowserInit is undefined
  Stack:
    tabEventListener@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/tabs/tab-firefox.js:312:33
@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/tabs/tab-firefox.js:335:39
emitOnObject@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:112:9
emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:89:38
emitOnObject@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:112:9
emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:89:38
emitOnObject@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:123:45
emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:89:38
messageReceived@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/remote/parent.js:96:37



Expected results:

No error.

Comment 1

[Philip Chee]

Attachment: Patch v1 Minimal shim for gBrowserInit

Comment 2

[[e-mail]]

Comment on attachment 8702585 [details] [diff] [review]
Patch v1 Minimal shim for gBrowserInit

[The function should probably be called DelayedStartup - I actually thought we used to have that before at some point but I couldn't find it.]

Comment 3

[Philip Chee]

(In reply to [e-mail] from comment #2)
> [The function should probably be called DelayedStartup.
I changed the function name to DelayedStartup when I checked it in.

https://hg.mozilla.org/comm-central/rev/6b030496ed9e

Comment 4

[Philip Chee]

Comment on attachment 8702585 [details] [diff] [review]
Patch v1 Minimal shim for gBrowserInit

[Approval Request Comment]
Regression caused by (bug #): N/A Addon-SDK Compatibility fix
User impact if declined: SDK based addons may not work properly.
Testing completed (on m-c, etc.): Tested on m-c.
Risk to taking this patch (and alternatives if risky): None. compatibility fix.
String changes made by this patch: None.

Comment 5

[Philip Chee]

http://hg.mozilla.org/releases/comm-aurora/rev/c494ca9c666c
http://hg.mozilla.org/releases/comm-beta/rev/6286686b0b1c