Closed Bug 1232036 Opened 4 years ago Closed 4 years ago

Support js shells in mozregression

Categories

(Testing :: mozregression, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gkw, Assigned: parkouss)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

49 bytes, text/x-github-pull-request
wlach
: review+
Details | Review
During a f2f meetup in Orlando, it was agreed that we should also support js shells that are already compiled and uploaded to FTP/TaskCluster.

This way, we can rip out the code in autoBisect that downloads builds and migrate -T mode to pass in arguments for mozregression directly.

Sample TaskCluster js shell link: https://queue.taskcluster.net/v1/task/5HPeHGPaQzSAjxFGSfWZzw/artifacts/public/build/jsshell-mac64.zip
See Also: → 1232037
Attached file support js shells
This patch enable mozregression to operate on js shells. We are basically reusing what we do for firefox, except that that the file name to download is different and obviously running jsshell is also different.

I tested it on linux and windows. seems good to me for both interactive and non interactive runs.

For example,

>> mozregression -g 2015-12-01 -b 2015-12-03 --app jsshell --command `pwd`/testshell.sh

with this in testshell.sh file:

>> #!/bin/bash
>> 
>> echo "[JS SHELL testing]"
>> 
>> $MOZREGRESSION_BINARY <<EOF
>> quit(Math.random() > 0.5 ? 1 : 0);
>> EOF
>> 
>> exit $?
Assignee: nobody → j.parkouss
Status: NEW → ASSIGNED
Attachment #8697988 - Flags: review?(wlachance)
Comment on attachment 8697988 [details] [review]
support js shells

Code looks good! It would be nice to get some feedback from :gkw or someone similar on whether this implementation meets their needs (I suspect it does, but you never know).
Attachment #8697988 - Flags: review?(wlachance) → review+
Hi Gary!

Do you think that this implementation will do the job for you ? OFC we still need to implement other features such as the machine-readable output, I only ask for the jsshell expectation. See comment 1 for an automatic bisection usage.
Flags: needinfo?(gary)
Looks good to me for now, I'll be sure to file more follow-up bugs for issues / features later as we test it out. Thank you so much for implementing this!
Flags: needinfo?(gary) → needinfo?(j.parkouss)
Great, agreed. :)

Landed in https://github.com/mozilla/mozregression/commit/a809df527bbc8daeb149ad0e813d95739a1789fc and https://github.com/mozilla/mozregression/commit/b5b0b8c2afa9dbfde654dc87af5e44a7bf6a39b5.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Flags: needinfo?(j.parkouss)
Resolution: --- → FIXED
Blocks: 1236101
You need to log in before you can comment on or make changes to this bug.