Small videos with low framerate may fail to send over peerconnection

RESOLVED FIXED in Firefox 46

Status

()

Core
WebRTC: Audio/Video
P1
normal
Rank:
15
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: pehrsons, Assigned: pehrsons)

Tracking

unspecified
mozilla46
Points:
---

Firefox Tracking Flags

(firefox46 fixed)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
When a video track sent over a peerconnection changes resolution we reconfigure the encoder. If the video has recently had a very low framerate and the new resolution is low enough, we might be telling the encoder to use a minimum bitrate that is lower than a constant value defined by webrtc.org code.

In the fiddle at [1] we can reproduce this. Run per the below to see the error logged:
> NSPR_LOG_MODULES=webrtc_trace:65535 WEBRTC_TRACE_FILE=nspr ./mach run


[1] http://jsfiddle.net/ot29yhy4/
(Assignee)

Comment 1

3 years ago
Created attachment 8697697 [details] [diff] [review]
Do not set a too low send bitrate in VideoConduit
Assignee: nobody → pehrsons
Status: NEW → ASSIGNED
Attachment #8697697 - Flags: review?(rjesup)

Updated

3 years ago
Attachment #8697697 - Flags: review?(rjesup) → review+

Updated

3 years ago
backlog: --- → webrtc/webaudio+
Rank: 15
Keywords: checkin-needed
Priority: -- → P1
Hi, this failed to apply: renamed 1232046 -> 0001-Bug-1232046-Do-not-set-a-too-low-send-bitrate-in-Vid.patch
applying 0001-Bug-1232046-Do-not-set-a-too-low-send-bitrate-in-Vid.patch
patching file media/webrtc/signaling/src/media-conduit/VideoConduit.cpp
Hunk #2 FAILED at 1017
1 out of 2 hunks FAILED -- saving rejects to file media/webrtc/signaling/src/media-conduit/VideoConduit.cpp.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh 0001-Bug-1232046-Do-not-set-a-too-low-send-bitrate-in-Vid.patch
Flags: needinfo?(pehrsons)

Updated

3 years ago
Keywords: checkin-needed
(Assignee)

Comment 3

3 years ago
Created attachment 8700891 [details] [diff] [review]
Do not set a too low send bitrate in VideoConduit

Rebased on current m-c. Carries forward r=jesup.
Attachment #8697697 - Attachment is obsolete: true
Flags: needinfo?(pehrsons)
Attachment #8700891 - Flags: review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8f89a903f225
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.