1232046 - Small videos with low framerate may fail to send over peerconnection

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P1)

Description

[Andreas Pehrson [:pehrsons]]

When a video track sent over a peerconnection changes resolution we reconfigure the encoder. If the video has recently had a very low framerate and the new resolution is low enough, we might be telling the encoder to use a minimum bitrate that is lower than a constant value defined by webrtc.org code.

In the fiddle at [1] we can reproduce this. Run per the below to see the error logged:
> NSPR_LOG_MODULES=webrtc_trace:65535 WEBRTC_TRACE_FILE=nspr ./mach run


[1] http://jsfiddle.net/ot29yhy4/

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: Do not set a too low send bitrate in VideoConduit

Comment 2

[Carsten Book [:Tomcat]]

Hi, this failed to apply: renamed 1232046 -> 0001-Bug-1232046-Do-not-set-a-too-low-send-bitrate-in-Vid.patch
applying 0001-Bug-1232046-Do-not-set-a-too-low-send-bitrate-in-Vid.patch
patching file media/webrtc/signaling/src/media-conduit/VideoConduit.cpp
Hunk #2 FAILED at 1017
1 out of 2 hunks FAILED -- saving rejects to file media/webrtc/signaling/src/media-conduit/VideoConduit.cpp.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh 0001-Bug-1232046-Do-not-set-a-too-low-send-bitrate-in-Vid.patch

Comment 3

[Andreas Pehrson [:pehrsons]]

Attachment: Do not set a too low send bitrate in VideoConduit

Rebased on current m-c. Carries forward r=jesup.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8f89a903f225

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8f89a903f225