1232051 - [TV][2.5] Marketplace UI should show strings (not just API data) localized for the user

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect, P2)

Description

[David Durst [:ddurst]]

Note: the templates for the UI should localize for the user. While the data should be returned from the API, the rest of the strings in the UI need to also be localized.

Comment 1

[Josh Cheng [:josh]]

Hi David, 
Does current TV API provide l10n support?
I think we also need to check content team how many different languages of content we are supporting to weight in whether this is in 2.5 scope.

Comment 2

[David Durst [:ddurst]]

It does. It uses the Accept-Language header from the request, though it can be streamlined/overridden by the 'lang' querystring param.

http://firefox-marketplace-api.readthedocs.org/en/latest/topics/overview.html#language

Comment 3

[Josh Cheng [:josh]]

Hi Joseph,
Can you check whether your code does send Accept-Language header from the request to get support languages?

Comment 4

[Joseph Yeh [:joseph]]

I think this feature is included in marketplace-core-modules, so no extra code is needed. And I also figure out how the UI strings can be localized in fireplace. Once we have all the l10n strings, all we need is to  put them into correct format.

Comment 5

[Davor Spasovski [:spasovski]]

Hi Joseph. I'll also comment in the github commit (seems I missed it in the initial review) but we'll need to send the translatable strings to the underscore function {{ _('some text to translate') }} in the templates and translated API responses to the 'translate' filter like {{ app.name|translate(app) }}

Comment 6

[Joseph Yeh [:joseph]]

Hi Dover, I am not sure where should I use the 'translate' filter. Is it only for app.name or is there any attributes that also need too?

I send the pull request out, maybe you can give me some advise there. Thanks.

Comment 7

[Joseph Yeh [:joseph]]

Attachment: jostw:josyeh/Marketplace/master/Bug1232051 > mozilla-b2g:master

Hi Davor, can you help me with this patch? Thanks!

Comment 8

[Joseph Yeh [:joseph]]

Comment on attachment 8703936 [details] [review]
jostw:josyeh/Marketplace/master/Bug1232051 > mozilla-b2g:master

Hi Davor, I have fixed the l10n of 'by {author}' and I also added another commit which change the wording of 'Marketplace' to 'Web Apps'.

Please let me know if there are any code that need further improvement, thanks :)

Comment 9

[Joseph Yeh [:joseph]]

Landed in marketplace-tv-front-end master.

https://github.com/mozilla-b2g/marketplace-tv-front-end/pull/16

Comment 10

[Joseph Yeh [:joseph]]

Landed in marketplace-tv-front-end master.

https://github.com/mozilla-b2g/marketplace-tv-front-end/commit/0bbbeb8415b3d8b934dd694e882df95b1eac4bff