1232156 - When closing window with CTRL- F4, the FullScreen on Video is not closed.

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect, P3)

Description

[ithompson4]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:43.0) Gecko/20100101 Firefox/43.0
Build ID: 20151203163240

Steps to reproduce:


* Navigate to YouTube video
* Click on Fullscreen on video
* Close window with ctrl-F4
* Start Firefox again



Actual results:

When closing window with CTRL- F4, the FullScreen on Video is not closed.


Expected results:

When closing window with CTRL- F4, the FullScreen on Video is closed

Comment 1

[ithompson4]

Attachment: Bug_1232156.png

Pressing CTRL-F4 failed to close this YouTube video for Firefox 44.0a2 Developer Edition(2015-12-10)

Comment 2

[ithompson4]

This is linked to Bug 1137009 - Video fullscreen confuses itself with F11 fullscreen state. Things work OK for Firefox 42.0 and 43.0b9.;but for Firefox 44.0a2 Developer Edition(2015-12-10) when closing the window with CTRL- F4, the FullScreen on Video is not closed.

Comment 3

[Benjamin Smedberg]

Xidorn, is this something you can look into?

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

I cannot reproduce this issue on my Windows 10 with Firefox 44.0a2 (2015-12-14).

Also, a bug reproducible on Aurora but not Beta may relate to e10s, you should also try this with non-e10s window on Aurora. I cannot reproduce this issue either with or without e10s enabled, though.

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Nom'ing for tracking by e10s team. 

Jim, does this issue sound familiar? Xidorn seems to think this may be e10s related.

Comment 6

[Jim Mathies [:jimm]]

(In reply to Ritu Kothari (:ritu) from comment #5)
> Nom'ing for tracking by e10s team. 
> 
> Jim, does this issue sound familiar? Xidorn seems to think this may be e10s
> related.

Haven't seen this reported before. Looks like this should be split into two bugs. First, closing fullscreen with alt-f4 shouldn't close the browser, and second, closing with alt-f4 and e10s leaves a zombie firefox.exe process. If you fix the first, the seconds gets fixed with it. The first is not e10s specific.

Comment 7

[Jim Mathies [:jimm]]

I think this is a dom fullscreen bug first and foremost.

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Thanks Jim. Smaug, since this might be a DOM issue, I though of pinging you for help with investigation and perhaps provide a fix.

Comment 9

[Olli Pettay [:smaug][[e-mail]](vacation until July 14)]

I can't reproduce this on linux. tested beta, aurora and nightly. e10s and non-e10s.

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Smaug, this was reported on FF43. Would you be able to try that with FF43? If you cannot repro on that either, I will ask the bug opener to try the same scenario on Nightly/Aurora/Beta and ultimately resolve as wfm.

Comment 11

[Olli Pettay [:smaug][[e-mail]](vacation until July 14)]

Can't reproduce on FF43 either.

Comment 12

[Brad Lassey [:blassey] (use needinfo?)]

I can't reproduce on nightly. Xidorn, can you?

Comment 13

[Xidorn Quan [:xidorn] UTC+10]

No, I can't either, on Nightly e10s and non-e10s.

Comment 14

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

[e-mail], are you still hitting this issue on a latest Nightly/Aurora build?

Comment 15

[ithompson4]

I have rerun the tests 3 times using the same steps as before using the same machine and Operating System (Windows 7).

Scenario 1 used Firefox 44.0b4

Scenario 2 used Firefox 44.0a2 Developer Edition(2015-12-10)

Scenario 3 used Firefox 45.0a2 Developer Edition(2015-12-31) which I assume is the latest nightly build.

With the Scenario 1 there was no problem.  CTRL- F4, closed the Full Screen on Video as expected.

But for BOTH Scenarios 2 and 3 the test failed i.e. when closing window with CTRL- F4, the Full Screen on Video is not closed.

Comment 16

[Olli Pettay [:smaug][[e-mail]](vacation until July 14)]

Latest nightly is 2016-01-02 (or is it already -01-03), Firefox 46
https://nightly.mozilla.org/

Comment 17

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Based on comment 15, I am setting 44 as unaffected as scenario1 is working. Given that this repros only with DevEdition (similarity I am drawing between scenario 2 and scenario 3) I am tracking it for 45.

Comment 18

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking for 46 as well. Andrei can your team have a shot at reproducing this in Win 7 on nightly?

Comment 19

[Mihai Boldan, Desktop QA [:mboldan]]

I was not able to reproduce this issue on Windows 7 x64, using Firefox 46.0a1 (2016-01-14), Firefox 45.0a2 (2016-01-14), Firefox 44.0a2 (2015-12-10) and Firefox 43.0(20151208100201).
The test were made with the e10s enabled and disabled as well.
When using Ctrl- F4, the current tab is closed, what to me seems as expected. I encountered the same behavior on all the tested builds. 
I used STR from Comment 0 for the tests.
Let me know if I can help further.

Comment 20

[Sylvestre Ledru [:Sylvestre]]

Seems like it is rare and very hard to reproduce, not tracking anymore.

Comment 21

[Andrew Overholt [:overholt]]

Since we can't seem to reproduce this I'm going to close this as WORKSFORME.

[e-mail], if you can still reproduce this, please re-open and provide more detailed steps to do so and also details of your environment and if you have any add-ons installed. If you could take a little video of it happening with another device and attach that or link to it, that would also help. Thank you!