1232186 - Component.update and Component.delete are broken

Status: RESOLVED FIXED

(Bugzilla :: WebService, defect)

Description

[Frédéric Buclin]

First of all, both Component.update and Component.delete are inaccessible because they are not listed in PUBLIC_METHODS. Secondly, they do not work anyway because they try to call $user->can_admin_product() which doesn't exist.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 8697855 [details] [diff] [review]
patch, v1

Review of attachment 8697855 [details] [diff] [review]:
-----------------------------------------------------------------

Need to add changes to Bugzilla/API/1_0/Resource/Component.pm as well.

Comment 3

[Frédéric Buclin]

Attachment: patch, v2

Remind me why we have exactly the same duplicated code in both files?

Comment 4

[David Lawrence [:dkl]]

(In reply to Frédéric Buclin from comment #3)
> Created attachment 8699670 [details] [diff] [review]
> patch, v2
> 
> Remind me why we have exactly the same duplicated code in both files?

Yet is not ideal. We decided to do this as the XMLRPC/JSONRPC (Bugzilla/WebService/* files) will be going away in a near future release. I could not come up with a clean way to share the old code and still support versioning without a lot of hacking.

dkl

Comment 5

[David Lawrence [:dkl]]

Comment on attachment 8699670 [details] [diff] [review]
patch, v2

Review of attachment 8699670 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 6

[Frédéric Buclin]

To ssh://[e-mail]/bugzilla/bugzilla.git
   21b3145..fbd124b  master -> master