1232253 - [music][metadata] ID3 APIC frame using UTF-16 and image with odd number of bytes fails to parse

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Verson Xiong (Leave from Mozilla)]

Attachment: logcat_1544.txt

[1.Description]:
[Arieskk v2.5 & master][Flame v2.5 & master]Copy test.mp3(download from baidu music) to device and play it, device display deafult album, and the test mp3 file's cover image is missing.
Found time:15:44
Attachment: logcat_1544.txt,test.mp3 & misscover.png

[2.Testing Steps]: 
1. Copy test.mp3 to device.
2. Launch music and wait music app to update DB.
3. Play test file and observe test file's cover.

[3.Expected Result]: 
3. Test file playes normally and its built-in image is displayed.

[4.Actual Result]: 
3. Test file playes normally but its built-in image is missing.

[5.Reproduction build]: 
Aries KK v2.5 (Affected)
Build ID               20151211164946
Gaia Revision          062e0fa48c1b5d5156f6911a5a4519128fac3231
Gaia Date              2015-12-11 15:06:09
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ded0306e0d78528cdcb237c8b05543390f10ec96
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151211.160132
Firmware Date          Fri Dec 11 16:01:40 UTC 2015
Bootloader             s1

Aries KK master (Affected):
Build ID               20151213015711
Gaia Revision          d886e152b42e557db612470d3417fe2947cbdeee
Gaia Date              2015-12-10 21:39:23
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f07e71078bc8991f74c2101944c8f869c77f442a
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151213.011142
Firmware Date          Sun Dec 13 01:11:51 UTC 2015
Bootloader             s1

Flame KK v2.5 512mb (Affected)
Build ID               20151211164817
Gaia Revision          062e0fa48c1b5d5156f6911a5a4519128fac3231
Gaia Date              2015-12-11 15:06:09
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ded0306e0d78528cdcb237c8b05543390f10ec96
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151211.160256
Firmware Date          Fri Dec 11 16:03:05 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Flame KK Master 512mb (Affected)
Build ID               20151213030223
Gaia Revision          d886e152b42e557db612470d3417fe2947cbdeee
Gaia Date              2015-12-10 21:39:23
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f07e71078bc8991f74c2101944c8f869c77f442a
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151213.064610
Firmware Date          Sun Dec 13 06:46:23 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Flame KK v2.2 eng(Affected)
Build ID               20151213032511
Gaia Revision          885647d92208fb67574ced44004ab2f29d23cb45
Gaia Date              2015-10-07 13:05:24
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/772a4e56d15d
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151213.070300
Firmware Date          Sun Dec 13 07:03:12 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

[8.Note]:
buid-in image of test file's cover displayed normmally on android device.

Comment 1

[Verson Xiong (Leave from Mozilla)]

Attachment: misscover.png

Comment 2

[Verson Xiong (Leave from Mozilla)]

Attachment: test.mp3

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] jimporter:music-utf16-odd-art > mozilla-b2g:master

Comment 4

[Jim Porter (:squib)]

Comment on attachment 8703226 [details] [review]
[gaia] jimporter:music-utf16-odd-art > mozilla-b2g:master

Fixed with a test.

Comment 5

[Hubert Figuiere [:hub]]

Comment on attachment 8703226 [details] [review]
[gaia] jimporter:music-utf16-odd-art > mozilla-b2g:master

Ship it

Comment 6

[Jim Porter (:squib)]

Landed: https://github.com/mozilla-b2g/gaia/commit/887a1d7f2ab601fc40b923b4e16e6b9b48fc982e

Comment 7

[Shally Li（leave from Mozilla）]

Attachment: Verified_image.png

This bug has been verified as "pass" on the latest build of Flame KK master & Aries kk master by the STR in comment 0.

Actual results: Test file playes normally and its built-in image is displayed.
See attachment: Verified_image.png
Reproduce rate: 0/10

Device: Flame KK master build 512mb(Pass)
Build ID               20160110150206
Gaia Revision          0e6160a58b41b48a8e4bb75ab9e722d9491251f4
Gaia Date              2016-01-09 07:10:36
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/c33f30666b37dbceffb9fbe5089a668db8893a85
Gecko Version          46.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20160110.183734
Firmware Date          Sun Jan 10 18:37:47 EST 2016
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK master ( Pass )
Build ID               20160110234003
Gaia Revision          260e51a4262f75341e037e583dfc8f6835b5ab31
Gaia Date              2016-01-09 16:27:31
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/6020a4cb41a77a09484c24a5875bb221714c0e6a
Gecko Version          46.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20160111.001607
Firmware Date          Mon Jan 11 00:16:15 UTC 2016
Bootloader             s1