>>> My Info: GUI 0.6.0, using mozregression 2.0.1 STR: 1. Launch mozregression gui, start new bisection: firefox,32bit,opt 2. Press "Next" twice 3. Check "Search fix" checkbox; select last bad build == changeset 0dbac1acaca7ae2a767604fdbcf5105853518c88 select first good build == changeset d873179a7da024a8d42b73e571d64b1eb53efa63 (there's only 1 build between them: f7ee42669b87f05416eb785ab9db27b5c66de1a3) 4. Press "Finish" 5. Evaluate build as "Good" Result: I see an alert box "Bisection is done.", and the last tested build (f7ee42669b87f05416eb785ab9db27b5c66de1a3) disappears from Bisection progress pane Expectations: The last tested build shouldn't disappear This appears to be a recent regression of Mozregression GUI. Probably a duplicate.
Yep, thanks for reporting this. I saw that recently, and was about to report it - so this is not a duplicate. Indeed we remove that last item in the view, so the final pushlog url is incorrect (the last test is missing, just as you mentioned). I will look at it.
Assignee: nobody → j.parkouss
Status: NEW → ASSIGNED
Created attachment 8697981 [details] [review] do not delete the last tested step We were calling the finished slot twice (indeed, this is a regression from 6.0, with the bisection flow change) - and the side effect was the removal of the last step. This patch resolve the issue. Will, I'm asking you for a review. You can test it with what is said in comment 0. You can redirect the review to mikeling if you're not confident enough, but this is a part of the code that I believe I'm the only one to know in details; Thanks :arni2033 for the great bug report by the way. I really appreciate all the information you provided!
Attachment #8697981 - Flags: review?(wlachance)
Comment on attachment 8697981 [details] [review] do not delete the last tested step Yep, this looks fine to me. Obviously the lines you are deleting are old code.
Attachment #8697981 - Flags: review?(wlachance) → review+
Landed in https://github.com/mozilla/mozregression/commit/943d06d6b5ca3c23110b3d0352cd85b3781b1044. Will release a new gui version in next days.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.