1232337 - Drop support for non-SSE2 WebGL on Windows

Status: RESOLVED WORKSFORME

(Core :: Graphics: CanvasWebGL, defect)

Description

[Benoit Girard (:BenWa)]

Right now we believe that we're getting substantially worse performance on 32-bit windows because we're compiling ANGLE without SSE2. It appears that in a hot benchmark loop (UnityBench Particle) we get fload/fstore instructions instead of fmove. Compiling with SSE2 enabled should improve performance.

Assuming that the above assumptions are right, we should require SSE2 support on windows. SSE2 has been widely available since 2003 and we believe that the number of users who don't have SSE2 and are not blacklisted is likely insignificant > 0.1%.

Let's measure the improvement and if the above holds up we should go ahead.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Just go ahead and do it.  One code path is better than two.

Comment 2

[Benoit Girard (:BenWa)]

Yea, I don't plan on shipping both. I just want to see how close it gets us to 64-bit and make sure the speed improvement is measurable.

Comment 3

[Benoit Girard (:BenWa)]

Attachment: patch

I tried this patch. I get a cl.exe warning that I am overriding the arch flag and I see SSE2 instructions in the binary but the Particle score is identical.

Comment 4

[Benoit Girard (:BenWa)]

This bug is obsolete now.