1232390 - Add support for nice labels to the HeapAnalysesWorker

Status: RESOLVED FIXED

(DevTools :: Memory, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

bug 1231883 gives us the ability to use breakdowns to describe a single node in the heap graph, this bug is for using those breakdown descriptions to generate useful labels for the dominator tree view.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Use HeapSnapshot.describeNode to generate labels for nodes

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=566433abb42a

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8699638 [details] [diff] [review]
Use HeapSnapshot.describeNode to generate labels for nodes

Review of attachment 8699638 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, nice test coverage too

::: devtools/shared/heapsnapshot/DominatorTreeNode.js
@@ +11,5 @@
>  /**
>   * A single node in a dominator tree.
>   *
>   * @param {NodeId} nodeId
>   * @param {NodeSize} retainedSize

comments need updated

@@ +179,5 @@
>   * Go no deeper down the tree than `maxDepth` and only consider at most
>   * `maxSiblings` within any single node's children.
>   *
>   * @param {DominatorTree} dominatorTree
>   * @param {Number} maxDepth

updated comments

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b9f3786d8f60

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b9f3786d8f60

Comment 7

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel	        beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected