Closed
Bug 1232390
Opened 9 years ago
Closed 8 years ago
Add support for nice labels to the HeapAnalysesWorker
Categories
(DevTools :: Memory, defect)
DevTools
Memory
Tracking
(firefox46 fixed)
RESOLVED
FIXED
Firefox 46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file)
26.32 KB,
patch
|
jsantell
:
review+
|
Details | Diff | Splinter Review |
bug 1231883 gives us the ability to use breakdowns to describe a single node in the heap graph, this bug is for using those breakdown descriptions to generate useful labels for the dominator tree view.
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8699638 -
Flags: review?(jsantell)
Assignee | ||
Comment 3•8 years ago
|
||
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=566433abb42a
Comment 4•8 years ago
|
||
Comment on attachment 8699638 [details] [diff] [review] Use HeapSnapshot.describeNode to generate labels for nodes Review of attachment 8699638 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, nice test coverage too ::: devtools/shared/heapsnapshot/DominatorTreeNode.js @@ +11,5 @@ > /** > * A single node in a dominator tree. > * > * @param {NodeId} nodeId > * @param {NodeSize} retainedSize comments need updated @@ +179,5 @@ > * Go no deeper down the tree than `maxDepth` and only consider at most > * `maxSiblings` within any single node's children. > * > * @param {DominatorTree} dominatorTree > * @param {Number} maxDepth updated comments
Attachment #8699638 -
Flags: review?(jsantell) → review+
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b9f3786d8f60
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Comment 7•8 years ago
|
||
[bugday-20160323] Status: RESOLVED,FIXED -> UNVERIFIED Comments: STR: Not clear. Developer specific testing Component: Name Firefox Version 46.0b9 Build ID 20160322075646 Update Channel beta User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 OS Windows 7 SP1 x86_64 Expected Results: Developer specific testing Actual Results: As expected
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•