1232408 - E10SAccessibilityCheck relies on incorrect AppConstants variable XP_WIN

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Jim Mathies [:jimm]]

My mistake, I had a last minute drive by comment on this and I didn't test the change.

Comment 1

[Jim Mathies [:jimm]]

Attachment: MozReview Request: Bug 1232408 - E10SAccessibilityCheck relies on incorrect AppConstants variable XP_WIN. r?felipe

Bug 1232408 - E10SAccessibilityCheck relies on incorrect AppConstants variable XP_WIN. r?felipe

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8698136 [details]
MozReview Request: Bug 1232408 - E10SAccessibilityCheck relies on incorrect AppConstants variable XP_WIN. r?felipe

https://reviewboard.mozilla.org/r/27825/#review24997

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5b69961c4b35

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5b69961c4b35

Comment 5

[Jim Mathies [:jimm]]

Comment on attachment 8698136 [details]
MozReview Request: Bug 1232408 - E10SAccessibilityCheck relies on incorrect AppConstants variable XP_WIN. r?felipe

Approval Request Comment
[Feature/regressing bug #]:
a11y + e10s stability issues work
[User impact if declined]:
a11y users are gonna have a bad time.
[Describe test coverage new/current, TreeHerder]:
running in nightly for a couple days.
[Risks and why]:
we just merged so uplifting this shouldn't be a problem.
[String/UUID change made/needed]:
no

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8698136 [details]
MozReview Request: Bug 1232408 - E10SAccessibilityCheck relies on incorrect AppConstants variable XP_WIN. r?felipe

Needed for "e10s disabled in a11y mode", Aurora45+

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/270497f44add

Comment 8

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> INCOMPLETE

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel	        beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected