modernize Balrog's toolchain

RESOLVED FIXED

Status

Release Engineering
Balrog: Backend
RESOLVED FIXED
2 years ago
10 months ago

People

(Reporter: bhearsum, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Assignee)

Description

2 years ago
There's a number of things that are outdated, including:
* Crappy Makefile instead of tox
* Requirements files instead of setup.py
* Outdated versions of various libraries
* VirtualBox instead of Docker

The first two are no brainers to change, so I'll definitely do that. I want to take a stab at updating the libs, but it's not as important, so if it's a rathole it might not be worth it.

Switching to Docker might not even be desirable, because it may be a worse experience for non-Linux based devs, so that one needs some more thought.
(Assignee)

Comment 1

2 years ago
Created attachment 8698168 [details] [review]
use tox+taskcluster-github+setup.py for Balrog's main repo

I was going to flag Rail for this originally, because he knows tox and such things really well, but I didn't want to land this without your ack.
Attachment #8698168 - Flags: review?(nthomas)
Comment on attachment 8698168 [details] [review]
use tox+taskcluster-github+setup.py for Balrog's main repo

r+. There's a comment or two over on Github which are nits.
Attachment #8698168 - Flags: review?(nthomas) → review+
(Assignee)

Comment 3

2 years ago
Comment on attachment 8698168 [details] [review]
use tox+taskcluster-github+setup.py for Balrog's main repo

Rail - can you have a look at this too?
Attachment #8698168 - Flags: review?(rail)
Attachment #8698168 - Flags: review?(rail) → review+
(Assignee)

Comment 4

2 years ago
Comment on attachment 8698168 [details] [review]
use tox+taskcluster-github+setup.py for Balrog's main repo

Could one of you have a look at the new revs I added? Turns out I forgot to enable the rules tests until now =\.
Attachment #8698168 - Flags: review?(rail)
Attachment #8698168 - Flags: review?(nthomas)
Attachment #8698168 - Flags: review?(rail) → review+

Updated

2 years ago
Attachment #8698168 - Flags: review?(nthomas) → review+

Comment 5

2 years ago
Commits pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/89df3945753d6923b819018b7cf81092e081b47e
bug 1232436: modernize Balrog's toolchain.

https://github.com/mozilla/balrog/commit/078e23b660d621ae841af172b9f706231f1d5ecf
Merge pull request #33 from bhearsum/modernize-2

bug 1232436: modernize Balrog's toolchain with tox, taskcluster, and a setup.py. r=rail,nthomas
(Assignee)

Updated

2 years ago
Attachment #8698168 - Flags: checked-in+
(Assignee)

Comment 6

2 years ago
Created attachment 8698961 [details] [review]
fix MANIFEST.in to properly include auslib/migrate

Further explanation in the PR.
Attachment #8698961 - Flags: review?(rail)
Attachment #8698961 - Flags: review?(rail) → review+

Comment 7

2 years ago
Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/6b4922adee3abd4df9a961df40ae3eb9b34d6173
Merge pull request #35 from bhearsum/fix-manifest-for-migrate

bug 1232436: Fix MANIFEST.in to include all of auslib/migrate. r=rail
(Assignee)

Updated

2 years ago
Attachment #8698961 - Flags: checked-in+
(Assignee)

Comment 8

2 years ago
Created attachment 8698975 [details] [review]
upgrade the packages in the vendor library
Attachment #8698975 - Flags: review?(nthomas)
(Assignee)

Comment 9

2 years ago
Created attachment 8699185 [details] [review]
switch balrog-ui to taskcluster-github

Basically the same, but for balrog-ui. More comments in the PR.
Attachment #8699185 - Flags: review?(rail)
Comment on attachment 8699185 [details] [review]
switch balrog-ui to taskcluster-github

lgtm
Attachment #8699185 - Flags: review?(rail) → review+
Comment on attachment 8698975 [details] [review]
upgrade the packages in the vendor library

r+ if you add test_comparison.py back in.
Attachment #8698975 - Flags: review?(nthomas) → review+

Comment 12

2 years ago
Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/cadf2c0bdf4aefda4d7fa0da9ee6fb62ca5b9f6e
Merge pull request #36 from bhearsum/upgrade-all-the-packages

bug 1232436: modernize Balrog's toolchain - upgrade most of the vendor packages
(Assignee)

Updated

2 years ago
Attachment #8698975 - Flags: checked-in+
(Assignee)

Updated

2 years ago
Attachment #8699185 - Flags: checked-in+
(Assignee)

Comment 13

2 years ago
Everything outline in comment #0 is done, except switching to Docker. It looks like we may be going that way, but it's probably a fairly sizable task on its own, so I'll move that out to another bug if we settle on it.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED

Comment 14

10 months ago
Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/bc1f19ef42d1e2ce7f0888bee0b6f10b2c22f2f2
[balrog-ui] Merge pull request #12 from bhearsum/taskcluster

bug 1232436: Switch to Taskcluster + new Docker image. r=rail
You need to log in before you can comment on or make changes to this bug.