1232441 - Improve karma unit test coverage - include panel tests, error detection

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

The karma tests in the github repo are currently not running the panel tests.

Also, we've not got detection of errors, which we should be able to add quite easily.

Additionally, I'd like to get them running Chrome locally, even if we can't easily do it on travis at the moment.

Comment 1

[Mark Banner (:standard8)]

Attachment: Link to Github pull-request: https://github.com/mozilla/loop/pull/10

Most of the test changes are fixes for Google Chrome.

We add in shared/standalone testing on Google Chrome locally. Remote doesn't yet work - I tried it on travis but there wasn't an obvious quick fix. Bug 994962 can pick the CI side of things up.

I've changed how the head/tail work so that we explicitly remove the two addEventListeners we don't want, and leave the stubbing to the tests.

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8698564 [details] [review]
Link to Github pull-request: https://github.com/mozilla/loop/pull/10

Ok, I've now updated the PR with tools that let us run Chrome on Travis!

We run the latest Chrome stable which we have to get via a roundabout route. Travis has Chromium 37 installed by default and that doesn't support all the webrtc things we need for the unit tests (and the sdk will say unsupported for older than 39 anyway).

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

I'm happy to review this, but I didn't get time to today.  I'll pick it up in the morning, unless someone else has grabbed it by then.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8698564 [details] [review]
Link to Github pull-request: https://github.com/mozilla/loop/pull/10

Looks very nice!  Please re-request review when the comments have been addressed or responded to...

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 8698564 [details] [review]
Link to Github pull-request: https://github.com/mozilla/loop/pull/10

Updated PR

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8698564 [details] [review]
Link to Github pull-request: https://github.com/mozilla/loop/pull/10

Looks good!  r=dmose with comment changes addressed.

Comment 8

[Mark Banner (:standard8)]

https://github.com/mozilla/loop/commit/ffbadc830bf8b94774a778546a44dbbad7c19a94