Closed Bug 1232484 Opened 8 years ago Closed 8 years ago

SingleTiledContentClient doesn't play well with non-unified builds

Categories

(Core :: Graphics: Layers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
I was trying to land bug 1229052 which adds a new .cpp file to gfx/layers/moz.build and it broke windows builds because it shifted around which files get unified together. In particular it caused various compile failures in SingleTiledContentClient.* so I filed this bug to fix them.
Attachment #8698232 - Flags: review?(bgirard)
I have a build at https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1f604145573 with this patch which is green on windows (that's where the original failure was). Also doing a all-platforms build at https://treeherder.mozilla.org/#/jobs?repo=try&revision=533f27660bf7 to make sure it didn't break anywhere else.
Attachment #8698232 - Flags: review?(bgirard) → review+
https://hg.mozilla.org/mozilla-central/rev/f9360c8431c5
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: