Closed
Bug 1232581
Opened 10 years ago
Closed 9 years ago
[Taskcluster] Add docker image that use community-phone-builder script
Categories
(Taskcluster Graveyard :: Docker Images, defect)
Taskcluster Graveyard
Docker Images
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: sousmangoosta, Assigned: sousmangoosta)
References
Details
Attachments
(1 file)
|
4.19 KB,
patch
|
Details | Diff | Splinter Review |
Docker image that can be used by community builds, (restrictive scopes)
| Assignee | ||
Comment 1•10 years ago
|
||
Treeherder try of this patch : https://treeherder.mozilla.org/#/jobs?repo=try&revision=059236be919d
Assignee: nobody → sousmangoosta
Attachment #8698335 -
Flags: review?(wcosta)
| Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Comment 2•10 years ago
|
||
Comment on attachment 8698335 [details] [diff] [review]
5cdfb580215a.patch
Review of attachment 8698335 [details] [diff] [review]:
-----------------------------------------------------------------
Minor nits, but lgtm.
::: testing/docker/community-phone-builder/Dockerfile
@@ +7,5 @@
> +RUN yum install -y bc lzop java-1.7.0-openjdk
> +RUN npm install -g bower gulp apm grunt-cli
> +
> +# Set a default command useful for debugging
> +ENTRYPOINT ["validate_task.py"]
validate_task script doesn't make sense here, you can remove it.
::: testing/docker/community-phone-builder/build.sh
@@ +13,5 @@
> +test $TAG
> +
> +docker build -t $TAG .
> +
> +popd
This file is not necessary.
Attachment #8698335 -
Flags: review?(wcosta)
Comment 3•10 years ago
|
||
Ronald,
Answering your question on IRC, you should remove the file.
Comment 4•9 years ago
|
||
Ronald - due to the B2G pivot to Connected Devices (CD), I think these patches are probably not going to be integrated. If you're interested in picking up tasks related to CD, we can help connect you with the team. Thank you for your contributions, and I'm going to close this bug.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Updated•7 years ago
|
Product: Taskcluster → Taskcluster Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•