1232606 - Weird newsletter listed on French email control center

Status: VERIFIED FIXED

(Websites :: Basket, defect)

Description

[Théo Chevalier]

Attachment: Screenshot

In the control center, there is a weird "Download Firefox for iOS" newsletter below the Maker Party one, and it’s not displayed properly (see screenshot).

To display it, my settings are:

Country: France
Language: French

Comment 1

[Jessilyn Davis]

Thanks Theo!

Ben, can you take a look in the Basket admin controls to make sure that the settings for "Active" are set correctly (to not checked) for these download trigger emails? (And also test that if the newsletter is not active, that the download email still will fire?)

Comment 2

[Ben Niolet]

Attachment: Screen Shot 2015-12-15 at 12.34.19 PM.png

Huh. The newsletter is not checked to be "active" which I believe should mean it doesn't show in the pref center. Any thoughts, pmac?

Comment 3

[Paul [:pmac] McLanahan]

None at present. I saw this come in and checked around. Can't get that newsletter to show up for me, even if I use the form to send myself the iOS download email. I think we'll need to look into :tchevalier's account to see what's different. All that said I'm not sure why anything would look so odd yet. I'm still looking into that.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/fbdadd346b6da55da5991db99459847d6da7770c
Fix bug 1232606: Fix newsletter titles from basket

Problem was that most titles and descriptions for newsletters
are now in bedrock. The code path for ones coming from basket
had an errant comma at the end, making the value a tuple instead
of a string.

https://github.com/mozilla/bedrock/commit/98c511b9fd45e5c166afe52ba6b9559ced2d599d
Merge pull request #3662 from pmclanahan/fix-lazy-markup-newsletters-1232606

Fix bug 1232606: Fix newsletter titles from basket

Comment 5

[Jessilyn Davis]

Thanks Pmac!

Theo - can you verify that this is fixed for you?

Comment 6

[Paul [:pmac] McLanahan]

Won't be fixed yet. The code landed but it's not in production yet. Should be today hopefully.

Comment 7

[Paul [:pmac] McLanahan]

The fix is now in prod. Looks good to me. Let us know if it looks okay to you :tchevalier.

Comment 8

[Théo Chevalier]

(In reply to Paul [:pmac] McLanahan from comment #7)
> The fix is now in prod. Looks good to me. Let us know if it looks okay to
> you :tchevalier.

It LGTM, thank you!