Closed Bug 1232646 Opened 4 years ago Closed 4 years ago

[Static Analysis][Uninitialized fields] Function AudioTimelineEvent(MediaStream* ) from AudioEventTimeline.h

Categories

(Core :: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: andi, Assigned: andi)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: CID 1325710)

Attachments

(1 file)

The Static Analysis tool Coverity added that class members mCurve, mTimeConstant and mDuration are not initialized in the constructor. Even though there is no evident bug that is generated from this issue i think it should be better, for future proof, to initialize these 3 variables.
Attached patch Bug 1232646.diffSplinter Review
Attachment #8698418 - Flags: review?(cpearce)
Attachment #8698418 - Flags: review?(cpearce) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ec15b39b2180
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.