1232660 - [gui] Bisection Informations right-click menu text turns white when hovered

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[Fanolian]

Attachment: Text turns white when hovered

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20151214030220

Steps to reproduce:

Right click in Bisection Informations. Hover on a selectable item.


Actual results:

Text turns white instead of the item box being highlighted. See attachment.

Comment 1

[Julien Pagès (:parkouss)]

Oh, strange. Thanks for the bug report, I will try to reproduce it.

Comment 2

[Julien Pagès (:parkouss)]

Ok, reproducible on both linux and windows. Will look into this.

Comment 3

[Julien Pagès (:parkouss)]

Ok, so looks like a stylesheet issue from here: https://github.com/mozilla/mozregression/blob/91dc13a55125eb72db810f3eca4ededcc6b8f5ab/gui/mozregui/report.py#L302

We are applying a background color to the QPlainTextEdit - but we add that without any constraint, and so it is inherited by the child widgets.

We should set a constraint to apply the background-color rule on QPlainText objects only I guess, see:

http://doc.qt.io/qt-4.8/stylesheet.html

Let's see if someone is interested to fix this! Else I'll take care of it later.

Comment 4

[Saurabh Singhal [:saurabhs]]

Hi, I would like to work on this bug. Thanks.

Comment 5

[Julien Pagès (:parkouss)]

Sure!

Comment 6

[Saurabh Singhal [:saurabhs]]

Attachment: Pull Request

Comment 7

[Julien Pagès (:parkouss)]

Comment on attachment 8700085 [details] [review]
Pull Request

Looks good to me, thanks!

Comment 8

[Julien Pagès (:parkouss)]

Landed in https://github.com/mozilla/mozregression/commit/90e2fd578ed78db9f0b19c6fa9b5a48a5755d10c.