Fix comment typo s/MOOUSEMOVE/MOUSEMOVE/

RESOLVED FIXED in Firefox 46

Status

()

Core
Widget: Win32
--
trivial
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: chutten, Assigned: Shakthi Wijeratne, Mentored)

Tracking

unspecified
mozilla46
Points:
---

Firefox Tracking Flags

(firefox46 fixed)

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
Good first bug: a typo in a comment in widget/windows/nsWindow.cpp

I misspelled MOUSEMOVE as MOOUSEMOVE :S

Comment 1

3 years ago
a typo in a comment in widget/windows/nsWindow.cpp

Comment 2

3 years ago
Hello, i want to fix the bug and it's my first open source contribution. So, please help me how o find the file to be edited and how to submit the patch :)
(Reporter)

Comment 3

3 years ago
Sure!

Have you gotten the code? The path I provided to the file is relative to the folder that contains the code you obtained.

Comment 4

3 years ago
no sir :(
(Reporter)

Comment 5

3 years ago
Then you are only a couple steps away from making a contribution. In order to make a change to the code, you'll need a copy of the code to change. Here are some instructions on how to get started with that: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Source_Code/Mercurial 

Please let me know if you have any questions.
(Assignee)

Comment 6

3 years ago
Created attachment 8700462 [details] [diff] [review]
Fixed typo

Hi, I feel a bit silly submitting this patch but I felt it would be good to get familiar with the build tools and the patching process as this is my first patch.
Attachment #8700462 - Flags: review?(chutten)

Comment 7

3 years ago
Hi,

I'm interested to solve this bug. Could you please assign this to me.

Regards,
Dev
(Reporter)

Comment 8

3 years ago
Comment on attachment 8700462 [details] [diff] [review]
Fixed typo

Review of attachment 8700462 [details] [diff] [review]:
-----------------------------------------------------------------

That is the point of a [good first bug]: it should be just an exercise to get used to the tools. It's supposed to be dead-easy :)

Now you need to amend your commit to put r=chutten in the message (so they know who to come after with the pitchforks if this comment fix breaks the build), reupload (marking this one as obsolete, and putting review+ on it yourself), then put `checkin-needed` in Keywords so that the sherrifs will pick it up for integration.

Most of these things are automated if you use mozreview (http://mozilla-version-control-tools.readthedocs.org/en/latest/mozreview.html), which is worth your time to learn for your second bug :)
Attachment #8700462 - Flags: review?(chutten) → review+
(Reporter)

Updated

3 years ago
Assignee: nobody → shakthi
(Assignee)

Comment 9

2 years ago
Created attachment 8701879 [details] [diff] [review]
Fixed typo and added r=chutten

checkin-needed
Attachment #8700462 - Attachment is obsolete: true
Attachment #8701879 - Flags: review+
(Reporter)

Comment 10

2 years ago
"checkin-needed" needs to go into the Keywords field, otherwise perfect job!
Keywords: checkin-needed

Comment 12

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4cf5c2224d16
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.