Closed
Bug 1232669
Opened 7 years ago
Closed 7 years ago
Fix comment typo s/MOOUSEMOVE/MOUSEMOVE/
Categories
(Core :: Widget: Win32, defect)
Core
Widget: Win32
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: chutten, Assigned: shakthi, Mentored)
References
Details
(Whiteboard: [good first bug])
Attachments
(1 file, 1 obsolete file)
1.01 KB,
patch
|
shakthi
:
review+
|
Details | Diff | Splinter Review |
Good first bug: a typo in a comment in widget/windows/nsWindow.cpp I misspelled MOUSEMOVE as MOOUSEMOVE :S
Comment 1•7 years ago
|
||
a typo in a comment in widget/windows/nsWindow.cpp
Comment 2•7 years ago
|
||
Hello, i want to fix the bug and it's my first open source contribution. So, please help me how o find the file to be edited and how to submit the patch :)
Reporter | ||
Comment 3•7 years ago
|
||
Sure! Have you gotten the code? The path I provided to the file is relative to the folder that contains the code you obtained.
Comment 4•7 years ago
|
||
no sir :(
Reporter | ||
Comment 5•7 years ago
|
||
Then you are only a couple steps away from making a contribution. In order to make a change to the code, you'll need a copy of the code to change. Here are some instructions on how to get started with that: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Source_Code/Mercurial Please let me know if you have any questions.
Assignee | ||
Comment 6•7 years ago
|
||
Hi, I feel a bit silly submitting this patch but I felt it would be good to get familiar with the build tools and the patching process as this is my first patch.
Attachment #8700462 -
Flags: review?(chutten)
Comment 7•7 years ago
|
||
Hi, I'm interested to solve this bug. Could you please assign this to me. Regards, Dev
Reporter | ||
Comment 8•7 years ago
|
||
Comment on attachment 8700462 [details] [diff] [review] Fixed typo Review of attachment 8700462 [details] [diff] [review]: ----------------------------------------------------------------- That is the point of a [good first bug]: it should be just an exercise to get used to the tools. It's supposed to be dead-easy :) Now you need to amend your commit to put r=chutten in the message (so they know who to come after with the pitchforks if this comment fix breaks the build), reupload (marking this one as obsolete, and putting review+ on it yourself), then put `checkin-needed` in Keywords so that the sherrifs will pick it up for integration. Most of these things are automated if you use mozreview (http://mozilla-version-control-tools.readthedocs.org/en/latest/mozreview.html), which is worth your time to learn for your second bug :)
Attachment #8700462 -
Flags: review?(chutten) → review+
Reporter | ||
Updated•7 years ago
|
Assignee: nobody → shakthi
Assignee | ||
Comment 9•7 years ago
|
||
checkin-needed
Attachment #8700462 -
Attachment is obsolete: true
Attachment #8701879 -
Flags: review+
Reporter | ||
Comment 10•7 years ago
|
||
"checkin-needed" needs to go into the Keywords field, otherwise perfect job!
Keywords: checkin-needed
Comment 11•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4cf5c2224d16
Keywords: checkin-needed
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4cf5c2224d16
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•