Closed Bug 1232669 Opened 4 years ago Closed 4 years ago

Fix comment typo s/MOOUSEMOVE/MOUSEMOVE/

Categories

(Core :: Widget: Win32, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: chutten, Assigned: shakthi, Mentored)

References

Details

(Whiteboard: [good first bug])

Attachments

(1 file, 1 obsolete file)

Good first bug: a typo in a comment in widget/windows/nsWindow.cpp

I misspelled MOUSEMOVE as MOOUSEMOVE :S
a typo in a comment in widget/windows/nsWindow.cpp
Hello, i want to fix the bug and it's my first open source contribution. So, please help me how o find the file to be edited and how to submit the patch :)
Sure!

Have you gotten the code? The path I provided to the file is relative to the folder that contains the code you obtained.
no sir :(
Then you are only a couple steps away from making a contribution. In order to make a change to the code, you'll need a copy of the code to change. Here are some instructions on how to get started with that: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Source_Code/Mercurial 

Please let me know if you have any questions.
Attached patch Fixed typo (obsolete) — Splinter Review
Hi, I feel a bit silly submitting this patch but I felt it would be good to get familiar with the build tools and the patching process as this is my first patch.
Attachment #8700462 - Flags: review?(chutten)
Hi,

I'm interested to solve this bug. Could you please assign this to me.

Regards,
Dev
Comment on attachment 8700462 [details] [diff] [review]
Fixed typo

Review of attachment 8700462 [details] [diff] [review]:
-----------------------------------------------------------------

That is the point of a [good first bug]: it should be just an exercise to get used to the tools. It's supposed to be dead-easy :)

Now you need to amend your commit to put r=chutten in the message (so they know who to come after with the pitchforks if this comment fix breaks the build), reupload (marking this one as obsolete, and putting review+ on it yourself), then put `checkin-needed` in Keywords so that the sherrifs will pick it up for integration.

Most of these things are automated if you use mozreview (http://mozilla-version-control-tools.readthedocs.org/en/latest/mozreview.html), which is worth your time to learn for your second bug :)
Attachment #8700462 - Flags: review?(chutten) → review+
Assignee: nobody → shakthi
checkin-needed
Attachment #8700462 - Attachment is obsolete: true
Attachment #8701879 - Flags: review+
"checkin-needed" needs to go into the Keywords field, otherwise perfect job!
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4cf5c2224d16
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.