1232687 - Start system services from HAL

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Bluetooth currently starts it's Gonk daemon by itself. With more daemons to come, we should share this functionality in the HAL module.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f63255c367ac

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1232687: Add system-service interface to HAL

Does HAL's sandboxing refer to the content processes? In any case, I guess the sandboxes cannot start system services, so I made it fail hard.

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 1232687: Start bluetoothd with HAL service interface

Testing this patch on a device will require the patch from bug 1232670 as well.

Comment 4

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Comment on attachment 8698475 [details] [diff] [review]
[02] Bug 1232687: Start bluetoothd with HAL service interface

Review of attachment 8698475 [details] [diff] [review]:
-----------------------------------------------------------------

It looks good to me.

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1232687: Add system-service interface to HAL (v2)

Changes since v1:

  - made d'tor of |StartSystemServiceTimerCallback| protected
  - fix file order in moz.build

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

New session on try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2f5f3297ed9

Comment 7

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Try looks good now.

Comment 8

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8698908 [details] [diff] [review]
[01] Bug 1232687: Add system-service interface to HAL (v2)

Looks good to me! The only thing that you might want to change is to remove the changes that only remove whitespace for the sake of not polluting hg blame. It's no big deal though so land as you please.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/7670432d8866
https://hg.mozilla.org/integration/b2g-inbound/rev/ee9973fdfffd

Comment 10

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks for the reviews. I left in the whitespace fixes, as sooner or later someone will mess up the blame anyway, and the affected lines are mostly empty or comments. Shouldn't be too bad.

https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=ee9973fdfffd

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7670432d8866
https://hg.mozilla.org/mozilla-central/rev/ee9973fdfffd