Closed Bug 1232687 Opened 4 years ago Closed 4 years ago

Start system services from HAL

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox46 fixed)

RESOLVED FIXED
Tracking Status
firefox46 --- fixed

People

(Reporter: tzimmermann, Assigned: tzimmermann)

References

Details

Attachments

(2 files, 1 obsolete file)

Bluetooth currently starts it's Gonk daemon by itself. With more daemons to come, we should share this functionality in the HAL module.
Does HAL's sandboxing refer to the content processes? In any case, I guess the sandboxes cannot start system services, so I made it fail hard.
Attachment #8698473 - Flags: review?(gsvelto)
Testing this patch on a device will require the patch from bug 1232670 as well.
Attachment #8698475 - Flags: review?(shuang)
Comment on attachment 8698475 [details] [diff] [review]
[02] Bug 1232687: Start bluetoothd with HAL service interface

Review of attachment 8698475 [details] [diff] [review]:
-----------------------------------------------------------------

It looks good to me.
Attachment #8698475 - Flags: review?(shuang) → review+
Changes since v1:

  - made d'tor of |StartSystemServiceTimerCallback| protected
  - fix file order in moz.build
Attachment #8698473 - Attachment is obsolete: true
Attachment #8698473 - Flags: review?(gsvelto)
Attachment #8698908 - Flags: review?(gsvelto)
Try looks good now.
Comment on attachment 8698908 [details] [diff] [review]
[01] Bug 1232687: Add system-service interface to HAL (v2)

Looks good to me! The only thing that you might want to change is to remove the changes that only remove whitespace for the sake of not polluting hg blame. It's no big deal though so land as you please.
Attachment #8698908 - Flags: review?(gsvelto) → review+
Blocks: 1230032
Thanks for the reviews. I left in the whitespace fixes, as sooner or later someone will mess up the blame anyway, and the affected lines are mostly empty or comments. Shouldn't be too bad.

https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=ee9973fdfffd
https://hg.mozilla.org/mozilla-central/rev/7670432d8866
https://hg.mozilla.org/mozilla-central/rev/ee9973fdfffd
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
No longer blocks: 1230032
You need to log in before you can comment on or make changes to this bug.